Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

PIO-194: switch to DefaultAWSCredentialsProviderChain which also includes ProfileCredentialsProvider #496

Conversation

longliveenduro
Copy link
Contributor

@longliveenduro longliveenduro commented Nov 12, 2018

DefaultAWSCredentialsProviderChain also allows e.g. for AWS Instance Profile Roles and thus is more flexible and does not force developers to include credentials on their PredictionIO machines

@longliveenduro longliveenduro changed the title PIO-194: switch to DefaultAWSCredentialsProviderChain which also includes Prof… PIO-194: switch to DefaultAWSCredentialsProviderChain which also includes ProfileCredentialsProvider Nov 12, 2018
…ileCredentialsProvider, but also allows e.g. for AWS Instance Profile Roles and thus is more flexible and does not force developers to include credentials on their PredictionIO machines
@longliveenduro longliveenduro force-pushed the s3_storage_use_default_aws_credentials_chain branch from 1865446 to 43ca47e Compare November 12, 2018 15:46
Copy link
Contributor

@dszeto dszeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@dszeto dszeto merged commit 403a42c into apache:develop Dec 9, 2018
@longliveenduro longliveenduro deleted the s3_storage_use_default_aws_credentials_chain branch December 11, 2018 09:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants