Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve logs on failTimeoutMessages #1025

Merged
merged 1 commit into from
Jun 7, 2023
Merged

chore: improve logs on failTimeoutMessages #1025

merged 1 commit into from
Jun 7, 2023

Conversation

tisonkun
Copy link
Member

@tisonkun tisonkun commented Jun 7, 2023

This closes #1020.

@tisonkun
Copy link
Member Author

tisonkun commented Jun 7, 2023

Observe logs:

time="2023-06-07T08:51:33Z" level=info msg="Failing 1 messages on timeout 2s" producerID=1 producer_name=standalone-0-513 topic="persistent://public/default/my-topic-576569327"

Merging...

@tisonkun tisonkun merged commit 4c8246c into master Jun 7, 2023
6 checks passed
@tisonkun tisonkun deleted the tisonkun-patch-1 branch June 7, 2023 15:15
@RobertIndie RobertIndie added this to the v0.11.0 milestone Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nodece nodece nodece approved these changes

@lhotari lhotari Awaiting requested review from lhotari

@RobertIndie RobertIndie Awaiting requested review from RobertIndie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.11.0
Development

Successfully merging this pull request may close these issues.

Improve "Failing x messages" log message to include information that this was caused by send timeout
3 participants
@tisonkun @nodece @RobertIndie