fix: install openjdk-17 in Dockerfile #1037
Conversation
| @@ -25,7 +25,7 @@ ARG GOLANG_IMAGE=golang:latest | |||
| FROM $PULSAR_IMAGE as pulsar | |||
| FROM $GOLANG_IMAGE | |||
|
|
|||
| RUN apt-get update && apt-get install -y openjdk-17-jre-headless ca-certificates | |||
| RUN apt-get update && apt-get install -y openjdk-17-jre ca-certificates | |||
There was a problem hiding this comment.
The apachepulsar/pulsar:latest includes the JDK, so I think we can remove this line, could you try remove this line?
There was a problem hiding this comment.
https://github.com/crossoverJie/pulsar-client-go/actions/runs/5370408829/jobs/9742470767?pr=5
It seems like it cannot work properly, need Java runtime environment.
There was a problem hiding this comment.
| RUN apt-get update && apt-get install -y openjdk-17-jre ca-certificates | |
| RUN apt-get update && apt-get install -y ca-certificates openjdk-17-jre-headless |
According to https://bugs.launchpad.net/ubuntu/+source/ca-certificates-java/+bug/1998065, how about trying to install ca-certificates-java before java.
There was a problem hiding this comment.
According to bugs.launchpad.net/ubuntu/+source/ca-certificates-java/+bug/1998065, how about trying to install ca-certificates-java before java.
https://github.com/crossoverJie/pulsar-client-go/actions/runs/5373160775/jobs/9747260724?pr=5
RUN apt-get update && apt-get install -y ca-certificates-java openjdk-17-jre-headless
RUN apt-get update && apt-get install -y ca-certificates openjdk-17-jre-headless
Neither of those methods worked.
There was a problem hiding this comment.
Sorry, I didn't notice that we use the golang as the base image.
I suggest we use the pulsar as the base image, and then we just need to install the golang to the base image.
There was a problem hiding this comment.
Agree. That can be a follow-up. Let's fix the current situation first.
### Motivation There are related discussion records [here](#1037). It is recommended to switch the base image to `apachepulsar/pulsar`. ### Modifications Change base image to `apachepulsar/pulsar`.
Motivation
The master branch is broken:
See https://github.com/apache/pulsar-client-go/actions/runs/5368805969/jobs/9740647704?pr=999
Modifications
Use
openjdk-17-jreto replaceopenjdk-17-jre-headless.Verifying this change
Fix openjdk-17 crossoverJie/pulsar-client-go#4