Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: prepare sendrequest and move to internalSendAsync #1120

Merged
merged 3 commits into from
Oct 25, 2023

Conversation

tisonkun
Copy link
Member

@tisonkun tisonkun commented Oct 24, 2023

This refers to #1071. This follows up to #1118.

  1. Factor out updateSchema
  2. Factor out updateUncompressedPayload
  3. Factor out updateMetaData
  4. Factor out updateChunkInfo
  5. Move all these methods (expect updateChunkInfo which we will handle resource later) to internalSendAsync so that we populate the sendrequest in application thread
  6. Drop stopBlock

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / GoDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun tisonkun changed the title refactor: move cleanup logics to sr.done refactor: prepare sendrequest and move to internalSendAsync Oct 24, 2023
Signed-off-by: tison <wander4096@gmail.com>
Copy link
Member

@wolfstudy wolfstudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good refactor, LGTM +1

@tisonkun
Copy link
Member Author

Merging...

I'm rebasing #1121 onto this patch to fix two resource management issues with a unsplittable refactor.

@tisonkun tisonkun merged commit 793008e into apache:master Oct 25, 2023
6 checks passed
@tisonkun tisonkun deleted the srdone branch October 25, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants