Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve] update connection.lastDataReceivedTime when connection is ready #1145

Merged
merged 1 commit into from Dec 27, 2023

Conversation

gunli
Copy link
Contributor

@gunli gunli commented Dec 19, 2023

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

When I run client in K8s pods(keepAliveInterval=5s), connections are closed occasionally, I can't find the root cause, when I look into the code, I found c.lastDataReceivedTime is not updated in doHandshake(), if we have no data to send the first check of c.lastDataReceivedTime probably tell the connection is stale and close it, I think it is better to update c.lastDataReceivedTime when doHandshake() succeed.

newConnection()// the first set here
doHandshake()// not set here
internalReceivedCommand()// the second set here
runPingCheck()// the first check here

conn-close

Modifications

func (c *connection) doHandshake() bool {	
	c.log.Info("Connection is ready")
	c.setLastDataReceived(time.Now()) // update last data received time here
	c.changeState(connectionReady)
	return true
}

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable / docs / GoDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@gunli
Copy link
Contributor Author

gunli commented Dec 20, 2023

@tisonkun @RobertIndie

Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tisonkun tisonkun merged commit 443072b into apache:master Dec 27, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants