Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Name method to Consumer interface #321

Merged
merged 1 commit into from
Jul 10, 2020
Merged

Add Name method to Consumer interface #321

merged 1 commit into from
Jul 10, 2020

Conversation

shohi
Copy link
Contributor

@shohi shohi commented Jul 10, 2020 •
edited by wolfstudy

Motivation

Supports the Name() interface on the consumer side, allowing users to customize their own consumer name. If the user does not specify, a default consumer name will be randomly generated

Modifications

  • add consumerName field in consumer struct
  • add consumerName field in multiConsumer struct
  • add consumerName field in regexConsumer struct

@wolfstudy wolfstudy changed the title add Name method to Consumer interface Add Name method to Consumer interface Jul 10, 2020
@wolfstudy wolfstudy added this to the 0.2.0 milestone Jul 10, 2020
@wolfstudy
Copy link
Member

Thanks @shohi work for this, the change LGTM +1, I added some descriptive information about this pull request, PTAL

@merlimat merlimat merged commit 6188199 into apache:master Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merlimat merlimat merlimat approved these changes

@wolfstudy wolfstudy Awaiting requested review from wolfstudy

@aahmed-se aahmed-se Awaiting requested review from aahmed-se

Assignees

@shohi shohi

Labels
None yet
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shohi @wolfstudy @merlimat