Fix slice bounds out of range for readSingleMessage #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xiaolongran <xiaolongran@tencent.com>
Signed-off-by: xiaolongran <xiaolongran@tencent.com>
zymap
approved these changes
Jan 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: xiaolongran xiaolongran@tencent.com
Fixes #702
Motivation
As #702 desc, In some scenarios, when the
Read(size uint32) []byteinterface in Buffer is called, the panic of a slice out of bounds may occur. So in this pr, the judgment of boundary conditions is added. When the slice is out of bounds, aCommandAck_BatchDeSerializeErrorerror will be sent to the Broker to avoid the Go SDK process being down due to the panic.After adding the current logic, the effect of execution is as follows:
Modifications
Read()of Buffer