Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue 718] Fix nil pointer dereference in TopicNameWithoutPartitionPart #734

Merged
merged 1 commit into from
May 24, 2022

Conversation

hantmac
Copy link
Contributor

@hantmac hantmac commented Feb 22, 2022

Signed-off-by: hantmac hantmac@outlook.com

Fixes #<718>

Fix nil pointer dereference in TopicNameWithoutPartitionPart

Verifying this change

  • Make sure that the change passes the CI checks.

This change is already covered by existing tests, such as (please describe tests).

topic_name_test.go

Documentation

  • Does this pull request introduce a new feature? (no)

@wolfstudy wolfstudy added this to the v0.9.0 milestone Apr 13, 2022
Signed-off-by: hantmac <hantmac@outlook.com>

add error check

Signed-off-by: hantmac <hantmac@outlook.com>
Copy link
Member

@wolfstudy wolfstudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@wolfstudy wolfstudy merged commit a8270eb into apache:master May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic on NewReader - nil pointer dereference in TopicNameWithoutPartitionPart
2 participants