Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add basic authentication #778

Merged
merged 1 commit into from Jun 23, 2022
Merged

feat: add basic authentication #778

merged 1 commit into from Jun 23, 2022

Conversation

nodece
Copy link
Member

@nodece nodece commented May 25, 2022

Motivation

Miss the basic authentication.

Modifications

  • Add the basic authentication provider in internal/auth
  • Add factory method of basic authentication provider in client.go
  • Configure the basic authentication provider in integration tests

Documentation

  • Does this pull request introduce a new feature? yes
  • If yes, how is the feature documented? docs
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@nodece nodece closed this May 26, 2022
@nodece nodece reopened this May 26, 2022
liangyuanpeng
liangyuanpeng approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@liangyuanpeng liangyuanpeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@merlimat merlimat added this to the v0.9.0 milestone Jun 23, 2022
@merlimat merlimat merged commit 2ae909e into apache:master Jun 23, 2022
@momo-jun momo-jun mentioned this pull request Sep 14, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merlimat merlimat merlimat approved these changes

@liangyuanpeng liangyuanpeng liangyuanpeng approved these changes

Assignees
No one assigned
Labels
type/feature
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nodece @merlimat @liangyuanpeng