ci: add makefile #800
ci: add makefile #800
Conversation
pgier
force-pushed
the
add-makefile
branch
2 times, most recently
from
a04a45a
to
1034dc9
Compare
There was a problem hiding this comment.
I appreciate these changes. I would recommend use of Makefile. But it comes down to project and community's choice. @merlimat @cckellogg @wolfstudy can help decide the direction.
| ARG PULSAR_IMAGE=apachepulsar/pulsar:latest | ||
| ARG GOLANG_IMAGE=golang:latest |
There was a problem hiding this comment.
It'd better to keep the fixed version of base image. It is hard to trouble shoot problems if the latest points to a new version. That forces other PRs to deal with version problem.
There was a problem hiding this comment.
The version is fixed in the Makefile, so CI builds would always use the version set there. I set these to default to latest so that they don't become out of date. I can add a comment to the Dockerfile saying that these versions should be set via the Makefile or CLI.
There was a problem hiding this comment.
Added a comment about setting the version during build.
README.md
Outdated
| @@ -24,9 +24,9 @@ | |||
| [](https://github.com/apache/pulsar-client-go/blob/master/LICENSE) | |||
| # Apache Pulsar Go Client Library | |||
|
|
|||
| A Go client library for the [Apache Pulsar](https://pulsar.incubator.apache.org/) project. | |||
| A Go client library for [Apache Pulsar](https://pulsar.incubator.apache.org/). | |||
There was a problem hiding this comment.
the link should be updated, too :)
There was a problem hiding this comment.
The link is an old incubator link. It should be updated without incubator.
There was a problem hiding this comment.
Yep, it's updated now.
pgier
force-pushed
the
add-makefile
branch
2 times, most recently
from
10b6ad9
to
12ab1dc
Compare
- add a Makefile with basic build, test, clean, etc. - simplify the Dockerfile by moving some scripts and conf files to directories - update README - allow easy setting of GOLANG version and PULSAR version for testing Signed-off-by: Paul Gier <paul.gier@datastax.com>
Copy individual config files instead of directory when building the Dockerfile to catch any missing/incorrect files. Signed-off-by: Paul Gier <paul.gier@datastax.com>
Signed-off-by: Paul Gier <paul.gier@datastax.com>
Makefiles are commonly used for building golang projects.
Motivation
Add a Makefile to make it easier to remember the commands for building and testing the project. For example:
make buildinstead ofgo build ./pulsarmake testinstead of./docker-ci.shmake lintinstead ofgolangci-lint run