Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[client] Add MetricsRegisterer to ClientOptions #826

Merged
merged 2 commits into from
Aug 23, 2022

Conversation

pragkent
Copy link
Contributor

@pragkent pragkent commented Aug 10, 2022

Add ClientOptions.MetricsRegisterer for customizing prometheus
metrics registerer.

Motivation

Currently, client always use prometheus.DefaultRegisterer to register metrics, but the application might already have a registerer for metrics registering and exporting.

Modifications

Add ClientOptions.MetricsRegisterer to allow user to customize the metrics registerer. They can use the existed registerer in their applications.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)

Documentation

  • Does this pull request introduce a new feature? (yes)
  • If yes, how is the feature documented? (GoDocs)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

Add ClientOptions.MetricsRegisterer for customizing prometheus
metrics registerer.
@wolfstudy wolfstudy requested review from merlimat, cckellogg, freeznet and wolfstudy and removed request for merlimat and cckellogg August 22, 2022 08:18
@wolfstudy wolfstudy added this to the v0.10.0 milestone Aug 22, 2022
Copy link
Member

@wolfstudy wolfstudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, LGTM +1

@wolfstudy wolfstudy merged commit a09460e into apache:master Aug 23, 2022
@RobertIndie RobertIndie modified the milestones: v0.10.0, v0.9.0 Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants