Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuth2 KeyFileProvider - Use the DATA constant as prefix #866

Merged

Conversation

Niennienzz
Copy link
Contributor

Motivation

  • Code cleanup.

Modifications

  • A minor change to use the constant instead of a repeated string.

Verifying this change

  • Make sure that the change passes the CI checks.
  • This change is already covered by existing tests: TestNewAuthenticationOAuth2WithParams in pulsar/internal/auth/oauth2_test.go.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)

Documentation

  • Does this pull request introduce a new feature? - No.

@tisonkun
Copy link
Member

@nodece shall we merge this patch now or close it when we're merging #883?

@tisonkun
Copy link
Member

Merging...

@tisonkun tisonkun merged commit 39e11c7 into apache:master Nov 16, 2022
@RobertIndie RobertIndie added this to the v0.10.0 milestone Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants