Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use protocolbuffers instead of gogo #895

Merged
merged 2 commits into from
Dec 15, 2022
Merged

Conversation

nodece
Copy link
Member

@nodece nodece commented Nov 30, 2022

Fixes #862

Motivation

gogo has been deprecated, so use the protocolbuffers instead.

Modifications

  • Using google.golang.org/protobuf and re-generate the *.pb.go.

@nodece nodece force-pushed the use-protocolbuffers branch 5 times, most recently from 810466f to a708b65 Compare November 30, 2022 09:51
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
@nodece nodece requested review from wolfstudy, RobertIndie and merlimat and removed request for wolfstudy and RobertIndie December 1, 2022 07:11
Copy link
Contributor

@pgier pgier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Zixuan Liu <nodeces@gmail.com>
@nodece nodece merged commit 504e589 into apache:master Dec 15, 2022
@RobertIndie RobertIndie added this to the v0.10.0 milestone Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gogo/protobuf is deprecated
3 participants