Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] support for consumer event listener #904

Merged
merged 9 commits into from
Dec 13, 2022
Merged

[feat] support for consumer event listener #904

merged 9 commits into from
Dec 13, 2022

Conversation

labuladong
Copy link
Contributor

@labuladong labuladong commented Dec 7, 2022 •
edited
Loading

Fixes #901

Motivation

Support consumer active events.

Modifications

Add an option to consumers, add callback on BaseCommand_ACTIVE_CONSUMER_CHANGE.

Verifying this change

  • Make sure that the change passes the CI checks.

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / GoDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

dfarr
dfarr reviewed Dec 8, 2022
View reviewed changes
pulsar/consumer_partition.go Outdated Show resolved Hide resolved
@labuladong labuladong marked this pull request as ready for review December 9, 2022 05:10
@labuladong
Copy link
Contributor Author

/pulsarbot rerun-failure-checks

@labuladong labuladong requested a review from dfarr December 9, 2022 05:37
@labuladong
Copy link
Contributor Author

PTAL @codelipenghui @nodece @wolfstudy @RobertIndie

@labuladong
Copy link
Contributor Author

/pulsarbot rerun-failure-checks

RobertIndie
RobertIndie reviewed Dec 9, 2022
View reviewed changes
pulsar/consumer_test.go Outdated Show resolved Hide resolved
pulsar/consumer_test.go Outdated Show resolved Hide resolved
dfarr
dfarr approved these changes Dec 10, 2022
View reviewed changes
Copy link

@dfarr dfarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It took me longer than I care to admit to wire up my project to an alternate github dependency repo 😄, but I can confirm the event listener works as expected. Everything looks good to me 👍

pulsar/consumer_partition.go Show resolved Hide resolved
@labuladong
Copy link
Contributor Author

This pr is ready to merge

@RobertIndie RobertIndie merged commit 1fe9b62 into apache:master Dec 13, 2022
@labuladong labuladong deleted the feat-consumer-event branch December 13, 2022 02:12
@RobertIndie RobertIndie added this to the v0.10.0 milestone Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfarr dfarr dfarr approved these changes

@codelipenghui codelipenghui codelipenghui approved these changes

@RobertIndie RobertIndie RobertIndie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.10.0
Development

Successfully merging this pull request may close these issues.

Support consumer event listener
4 participants
@labuladong @dfarr @codelipenghui @RobertIndie