Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] update go version to 1.18 #911

Merged
merged 2 commits into from
Dec 16, 2022
Merged

Conversation

pgier
Copy link
Contributor

@pgier pgier commented Dec 13, 2022

Motivation

Upgrade module golang version from 1.15 to 1.18. Golang 1.18 is the oldest currently supported version. See: https://go.dev/doc/devel/release. Client applications using go 1.15 will still be able to compile against this module, but we should recommend that they upgrade their golang version or stick with a previous release of pulsar-client-go, e.g. 0.9.0.

Additional motivation for this is that I'd like to upgrade most/all of the dependencies in a separate commit, and some of them are likely not fully compatible with golang 1.15

Modifications

Updated the golang version in go.mod and ran go mod tidy.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is covered by existing CI which runs the build using various golang versions.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)
  • If a feature is not applicable for documentation, explain why? Added a minor doc update to the README
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

README.md Show resolved Hide resolved
- set go version in go.mod to 1.18
- run go mod tidy
- update readme
Copy link
Contributor

@zzzming zzzming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tisonkun
Copy link
Member

Client applications using go 1.15 will still be able to compile against this module

@pgier I'm curious about this statement. If we follow write some code depending on new added APIs, how can a lib compile in 1.15 compile with us as a dependency? Said os.ReadFile.

@pgier
Copy link
Contributor Author

pgier commented Dec 16, 2022

@tisonkun You are right at that point we will no longer be compatible with go 1.15. We should see a failure in the 1.15 integration tests at the point when a PR includes an incompatible change, and we would have to either not accept the change, or remove the 1.15 tests. My point was just that this change by itself doesn't make us incompatible with 1.15.

I'll work on upgrading dependencies next and see if anything fails, and we can decide whether it's worth upgrading specific incompatible deps.

@tisonkun
Copy link
Member

@pgier Thanks for your explanation! I see the IT cases whose matrix includes 1.15 now.

Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go. One comment inline.

README.md Outdated Show resolved Hide resolved
Co-authored-by: tison <wander4096@gmail.com>
@nodece nodece merged commit 4e24fce into apache:master Dec 16, 2022
@RobertIndie RobertIndie added this to the v0.10.0 milestone Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants