Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle nil value message correctly in table-view #930

Merged
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions pulsar/table_view_impl.go
Original file line number Diff line number Diff line change
Expand Up @@ -245,11 +245,17 @@ func (tv *TableViewImpl) handleMessage(msg Message) {
tv.dataMu.Lock()
defer tv.dataMu.Unlock()

payload := reflect.Indirect(reflect.New(tv.options.SchemaValueType)).Interface()
if err := msg.GetSchemaValue(&payload); err != nil {
tv.logger.Errorf("msg.GetSchemaValue() failed with %w; msg is %v", msg, err)
var payload interface{}
if len(msg.Payload()) == 0 {
delete(tv.data, msg.Key())
} else {
payload = reflect.Indirect(reflect.New(tv.options.SchemaValueType)).Interface()
if err := msg.GetSchemaValue(&payload); err != nil {
tv.logger.Errorf("msg.GetSchemaValue() failed with %w; msg is %v", msg, err)
}
tv.data[msg.Key()] = payload
}
tv.data[msg.Key()] = payload

for _, listener := range tv.listeners {
if err := listener(msg.Key(), payload); err != nil {
tv.logger.Errorf("table view listener failed for %v: %w", msg, err)
Expand Down
64 changes: 64 additions & 0 deletions pulsar/table_view_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -78,3 +78,67 @@ func TestTableView(t *testing.T) {
assert.Equal(t, valuePrefix+k, *(v.(*string)))
}
}

func TestPublishNilValue(t *testing.T) {
client, err := NewClient(ClientOptions{
URL: lookupURL,
})

assert.NoError(t, err)
defer client.Close()

topic := newTopicName()
schema := NewStringSchema(nil)

// create producer
producer, err := client.CreateProducer(ProducerOptions{
Topic: topic,
Schema: schema,
})
assert.NoError(t, err)
defer producer.Close()

// create table view
v := ""
tv, err := client.CreateTableView(TableViewOptions{
Topic: topic,
Schema: schema,
SchemaValueType: reflect.TypeOf(&v),
})
assert.NoError(t, err)
defer tv.Close()

_, err = producer.Send(context.Background(), &ProducerMessage{
Key: "key-1",
Value: "value-1",
})
assert.NoError(t, err)

for tv.Size() < 1 {
time.Sleep(time.Second * 1)
}
Demogorgon314 marked this conversation as resolved.
Show resolved Hide resolved

assert.Equal(t, *(tv.Get("key-1").(*string)), "value-1")

// Send nil value
_, err = producer.Send(context.Background(), &ProducerMessage{
Key: "key-1",
})
assert.NoError(t, err)

for tv.Size() >= 1 {
time.Sleep(time.Second * 1)
}

_, err = producer.Send(context.Background(), &ProducerMessage{
Key: "key-2",
Value: "value-2",
})
assert.NoError(t, err)

for tv.Size() < 1 {
time.Sleep(time.Second * 1)
}

assert.Equal(t, *(tv.Get("key-2").(*string)), "value-2")
}