[feature] Support batch index ACK #938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BewareMyPower
requested review from
cckellogg,
freeznet,
nodece,
RobertIndie,
wolfstudy and
Demogorgon314
BewareMyPower
force-pushed
the
bewaremypower/batch-index-ack
branch
from
fb9c50e
to
3e822e0
Compare
Fixes apache#894 ### Modifications Add an `EnableBatchIndexAcknowledgment` to specify whether batch index ACK is enabled. Since this feature requires the conversion between a bit set and its underlying long array, which is similar to Java's `BitSet`, this commit introduces github.com/bits-and-blooms/bitset dependency to replace the `big.Int` based implementation of the bit set. Add a `BatchSize()` method to `MessageId` to indicate the size of the `ack_set` field. When the batch index ACK happens, convert the `[]uint64` to the `[]int64` as the `ack_set` field in `CommandAck`. When receiving messages, convert the `ack_set` field in `CommandMessage` to filter the acknowledged single messages. Remove the duplicated code in `AckID` and `AckIDWithResponse`. ### Verifications `TestBatchIndexAck` is added to cover the case whether `AckWithResponse` is enabled and both individual and cumulative ACK.
BewareMyPower
force-pushed
the
bewaremypower/batch-index-ack
branch
from
3e822e0
to
2dfdabd
Compare
wolfstudy
reviewed
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #894
Modifications
Add an
EnableBatchIndexAcknowledgmentto specify whether batch index ACK is enabled. Since this feature requires the conversion between a bit set and its underlying long array, which is similar to Java'sBitSet, this commit introduces github.com/bits-and-blooms/bitset dependency to replace thebig.Intbased implementation of the bit set.Add a
BatchSize()method toMessageIdto indicate the size of theack_setfield. When the batch index ACK happens, convert the[]uint64to the[]int64as theack_setfield inCommandAck. When receiving messages, convert theack_setfield inCommandMessageto filter the acknowledged single messages.Remove the duplicated code in
AckIDandAckIDWithResponse.Verifications
TestBatchIndexAckis added to cover the case whetherAckWithResponseis enabled and both individual and cumulative ACK.