Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat][txn]Implement transactionCoordinatorClient #953

Merged
merged 9 commits into from
Feb 27, 2023
Merged

[feat][txn]Implement transactionCoordinatorClient #953

merged 9 commits into from
Feb 27, 2023

Conversation

liangyepianzhou
Copy link
Contributor

@liangyepianzhou liangyepianzhou commented Feb 13, 2023 •
edited
Loading

Master Issue:#932

Motivation

Implement transaction coordinator client.

Modifications

  1. Implement transaction coordinator
  2. implement transactionImpl
  3. Implement transaction in producer and consumer API

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / GoDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@liangyepianzhou
[feat][txn]Implement transactionCoordinatorClient
91803b0 
Master Issue:#932
### Motivation
Implement transaction coordinator client.
### Modifications
1. Implement transaction coordinator
2. implement transaction API
3. Add metric and test
@liangyepianzhou
Merge remote-tracking branch 'origin/master' into xiangying/txn/tc_cl…
802bbf4 
…ient
@liangyepianzhou liangyepianzhou mentioned this pull request Feb 14, 2023
Closed
1 task
@liangyepianzhou liangyepianzhou self-assigned this Feb 16, 2023
shibd
shibd reviewed Feb 21, 2023
View reviewed changes
Makefile Show resolved Hide resolved
pulsar/transactionCoordinatorClient.go Outdated Show resolved Hide resolved
pulsar/transaction_test.go Outdated Show resolved Hide resolved
pulsar/transaction_test.go Show resolved Hide resolved
nodece
nodece approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@nodece nodece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

BewareMyPower
BewareMyPower requested changes Feb 24, 2023
View reviewed changes
pulsar/client.go Outdated Show resolved Hide resolved
pulsar/transaction_coordinator_client.go Outdated Show resolved Hide resolved
pulsar/transaction_test.go Outdated Show resolved Hide resolved
pulsar/transaction_coordinator_client.go Outdated Show resolved Hide resolved
pulsar/transaction_coordinator_client.go Outdated Show resolved Hide resolved
pulsar/transaction_coordinator_client.go Outdated Show resolved Hide resolved
pulsar/transaction_coordinator_client.go Outdated Show resolved Hide resolved
pulsar/client_impl_test.go Show resolved Hide resolved
@nodece nodece merged commit e2ea255 into master Feb 27, 2023
@liangyepianzhou liangyepianzhou deleted the xiangying/txn/tc_client branch February 27, 2023 02:39
BewareMyPower added a commit to BewareMyPower/pulsar-client-go that referenced this pull request Feb 28, 2023
@BewareMyPower
Fix flaky Key_Shared subscription related tests
0eb844f 
### Motivation

After apache#953, the Pulsar
version was upgraded from 2.8.3 to 2.10.3. However,
[PIP-119](apache/pulsar#13352) changed the
default value of `subscriptionKeySharedUseConsistentHashing` to true,
which leads to the flakiness of Key_Shared subscription related tests.

Example: https://github.com/apache/pulsar-client-go/actions/runs/4291098473/jobs/7475868787

### Modifications

Configure `subscriptionKeySharedUseConsistentHashing` with `false`.
@BewareMyPower BewareMyPower mentioned this pull request Feb 28, 2023
Merged
@shibd shibd mentioned this pull request Feb 28, 2023
Closed
shibd pushed a commit that referenced this pull request Mar 1, 2023
@BewareMyPower
Fix flaky Key_Shared subscription related tests (#970)
d60bff6 
### Motivation

After #953, the Pulsar
version was upgraded from 2.8.3 to 2.10.3. However,
[PIP-119](apache/pulsar#13352) changed the
default value of `subscriptionKeySharedUseConsistentHashing` to true,
which leads to the flakiness of Key_Shared subscription related tests.

Example: https://github.com/apache/pulsar-client-go/actions/runs/4291098473/jobs/7475868787

### Modifications

Configure `subscriptionKeySharedUseConsistentHashing` with `false`.
@BewareMyPower BewareMyPower mentioned this pull request Mar 23, 2023
Merged
1 task
@RobertIndie RobertIndie added this to the v0.10.0 milestone Mar 27, 2023
@geniusjoe geniusjoe mentioned this pull request Jun 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shibd shibd shibd left review comments

@nodece nodece nodece approved these changes

@BewareMyPower BewareMyPower BewareMyPower approved these changes

@congbobo184 congbobo184 Awaiting requested review from congbobo184

@poorbarcode poorbarcode Awaiting requested review from poorbarcode

@RobertIndie RobertIndie Awaiting requested review from RobertIndie

Assignees

@liangyepianzhou liangyepianzhou

Labels
None yet
Projects
None yet
Milestone
v0.10.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@liangyepianzhou @nodece @BewareMyPower @shibd @RobertIndie