Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Expose the chunk config of consumer to the reader #987

Merged
merged 6 commits into from
Mar 9, 2023

Conversation

CrazyCollin
Copy link
Contributor

@CrazyCollin CrazyCollin commented Mar 8, 2023

Fixes #935

Motivation

Support expose the chunk config of consumer to the reader

Modifications

Add chunk config related filed in ReaderOptions struct.

Verifying this change

This change added tests and can be verified as follows:

  • Added test for specified and default chunk options in reader.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)

@CrazyCollin
Copy link
Contributor Author

Hi, @RobertIndie @shibd ,can you review it for me when you are free, many thanks.

Copy link
Member

@RobertIndie RobertIndie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR. Please add some tests to verify this PR.

You can add a test to verify that the configuration of the reader can be fed into the internal consumer reader.pc.

pulsar/reader_test.go Outdated Show resolved Hide resolved
pulsar/reader_test.go Outdated Show resolved Hide resolved
pulsar/reader.go Outdated Show resolved Hide resolved
Co-authored-by: Zike Yang <zike@apache.org>
@shibd shibd merged commit e269c42 into apache:master Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] Expose the chunk config of consumer to the reader
3 participants