-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Expose the chunk config of consumer to the reader #987
Merged
shibd
merged 6 commits into
apache:master
from
CrazyCollin:dev/expose_chunk_config_to_reader
Mar 9, 2023
Merged
[feat] Expose the chunk config of consumer to the reader #987
shibd
merged 6 commits into
apache:master
from
CrazyCollin:dev/expose_chunk_config_to_reader
Mar 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi, @RobertIndie @shibd ,can you review it for me when you are free, many thanks. |
RobertIndie
reviewed
Mar 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR. Please add some tests to verify this PR.
You can add a test to verify that the configuration of the reader can be fed into the internal consumer reader.pc
.
RobertIndie
reviewed
Mar 9, 2023
RobertIndie
reviewed
Mar 9, 2023
Co-authored-by: Zike Yang <zike@apache.org>
RobertIndie
approved these changes
Mar 9, 2023
shibd
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #935
Motivation
Support expose the chunk config of consumer to the reader
Modifications
Add chunk config related filed in
ReaderOptions
struct.Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
If
yes
was chosen, please highlight the changes