Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not add license header to tarball file #197

Merged
merged 1 commit into from
Mar 2, 2022

Conversation

massakam
Copy link
Contributor

@massakam massakam commented Mar 1, 2022

There is a step in the release process to run npm run license: addheader, which will add the license header to the source file archive (pulsar-client-node-1.X.0.tar.gz) and corrupt the file.

To avoid this, I modified the setting so that the license header is not added to files with the file extension .gz.

@massakam massakam self-assigned this Mar 1, 2022
Copy link
Contributor

@hrsakai hrsakai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hrsakai hrsakai merged commit 8ebe33b into apache:master Mar 2, 2022
@massakam massakam deleted the fix-license-check-and-add-config branch March 2, 2022 02:17
@massakam massakam added this to the 1.6.2 milestone Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants