Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary / at the end of CPP_CLIENT_BASE_URL #294

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

massakam
Copy link
Contributor

@massakam massakam commented Feb 7, 2023

Motivation

CPP_CLIENT_BASE_URL ends with /, which seems unnecessary.

$ find . -type f | xargs grep --color 'CPP_CLIENT_BASE_URL'

./pkg/linux/download-cpp-client.sh:  curl -L -O ${CPP_CLIENT_BASE_URL}/deb-${PLATFORM}/apache-pulsar-client-dev.deb
./pkg/linux/download-cpp-client.sh:  curl -L -O ${CPP_CLIENT_BASE_URL}/apk-${PLATFORM}/${UNAME_ARCH}/apache-pulsar-client-dev-${CPP_CLIENT_VERSION}-r0.apk
./pkg/linux/download-cpp-client.sh:  curl -L -O ${CPP_CLIENT_BASE_URL}/rpm-${PLATFORM}/${UNAME_ARCH}/apache-pulsar-client-devel-${CPP_CLIENT_VERSION}-1.${UNAME_ARCH}.rpm
./pkg/mac/build-cpp-lib.sh:curl -O -L "$CPP_CLIENT_BASE_URL"/apache-pulsar-client-cpp-${CPP_CLIENT_VERSION}.tar.gz
./pkg/windows/download-cpp-client.bat:curl -O -L %CPP_CLIENT_BASE_URL%/%arch%-windows-static.tar.gz
./pulsar-client-cpp.txt:CPP_CLIENT_BASE_URL=https://archive.apache.org/dist/pulsar/pulsar-client-cpp-3.1.1/

Verifying this change

  • Make sure that the change passes the CI checks.

Documentation

  • doc-required
  • doc-not-needed
  • doc
  • doc-complete

@massakam massakam self-assigned this Feb 7, 2023
@massakam massakam added this to the 1.9.0 milestone Feb 7, 2023
@shibd shibd merged commit 9ec1703 into apache:master Feb 7, 2023
@massakam massakam deleted the fix-cpp-client-url branch February 7, 2023 07:17
shibd pushed a commit to shibd/pulsar-client-node that referenced this pull request Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants