Make acknowledge APIs synchronous and improve the documents #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes apache#114 ### Motivation Currently the `acknowledge` and `acknowledge_cumulative` methods are all asynchronous. Even if any error happened, no exception would be raised. For example, when acknowledging cumulatively on a consumer whose consumer type is Shared or KeyShared, no error happens. ### Modifications - Change these methods to synchronous and raise exceptions if the acknowledgment failed. - Add `PulsarTest.test_acknowledge_failed` to test these failed cases. - Improve the documents to describe which exceptions could be raised in which cases.
BewareMyPower
requested review from
merlimat,
RobertIndie,
tisonkun,
Demogorgon314 and
shibd
|
|
merlimat
approved these changes
May 24, 2023
BewareMyPower
added a commit
to BewareMyPower/pulsar-client-python
that referenced
this pull request
Dec 25, 2023
Fixes apache#178 ### Motivation apache#121 introduces a regression that when `negative_acknowledge` accepts a message ID, the underlying `acknowledgeAsync` method will be called. ### Modifications Fix the `Consumer_negative_acknowledge_message_id` method and add the test for negative acknowledging message IDs in `test_redelivery_count`.
BewareMyPower
added a commit
that referenced
this pull request
Dec 26, 2023
Fixes #178 ### Motivation #121 introduces a regression that when `negative_acknowledge` accepts a message ID, the underlying `acknowledgeAsync` method will be called. ### Modifications Fix the `Consumer_negative_acknowledge_message_id` method and add the test for negative acknowledging message IDs in `test_redelivery_count`.
RobertIndie
pushed a commit
that referenced
this pull request
Dec 26, 2023
Fixes #178 ### Motivation #121 introduces a regression that when `negative_acknowledge` accepts a message ID, the underlying `acknowledgeAsync` method will be called. ### Modifications Fix the `Consumer_negative_acknowledge_message_id` method and add the test for negative acknowledging message IDs in `test_redelivery_count`. (cherry picked from commit b9c7219)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #114
Motivation
Currently the
acknowledgeandacknowledge_cumulativemethods are all asynchronous. Even if any error happened, no exception would be raised. For example, when acknowledging cumulatively on a consumer whose consumer type is Shared or KeyShared, no error happens.Modifications
PulsarTest.test_acknowledge_failedto test these failed cases.