Fix wrong place for license scan badge in README.md (#192) #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuteng
reviewed
Sep 16, 2019
| @@ -2,6 +2,8 @@ | |||
|
|
|||
| Apache Pulsar manager is a web-based GUI management tool for managing and monitoring Pulsar. | |||
|
|
|||
| [](https://app.fossa.io/projects/git%2Bgithub.com%2Fstreamnative%2Fpulsar-manager?ref=badge_shield) | |||
There was a problem hiding this comment.
Thank you very much for your contribution.
What do you think of putting the badge at the top of the content
Apache Pulsar manager is a web-based GUI management tool for managing and monitoring Pulsar.
There was a problem hiding this comment.
OK, I shall make another commit.
But should I put this badge below or beyond the chapter line of Apache Pulsar manager?
There was a problem hiding this comment.
Yep, agree with that.
sijie
approved these changes
Sep 16, 2019
tuteng
approved these changes
Sep 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the badge from inner chapter to file head.