Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong place for license scan badge in README.md (#192) #193

Merged
merged 4 commits into from Sep 17, 2019
Merged

Fix wrong place for license scan badge in README.md (#192) #193

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
011cdb3
Fix wrong place for license scan badge in README.md (#192)
biaoma-ty Sep 16, 2019
96cf114
Fix wrong place for license scan badge in README.md (#192)
biaoma-ty Sep 16, 2019
09f38fb
modify place for license scan badge in README.md (#192)
biaoma-ty Sep 16, 2019
6566d93
Merge branch 'master' into master
sijie Sep 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
@@ -1,5 +1,7 @@
# Apache Pulsar manager

[![FOSSA Status](https://app.fossa.io/api/projects/git%2Bgithub.com%2Fstreamnative%2Fpulsar-manager.svg?type=shield)](https://app.fossa.io/projects/git%2Bgithub.com%2Fstreamnative%2Fpulsar-manager?ref=badge_shield)
Copy link
Member

@tuteng tuteng Sep 16, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution.
What do you think of putting the badge at the top of the content

FOSSA Status

Apache Pulsar manager is a web-based GUI management tool for managing and monitoring Pulsar.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I shall make another commit.
But should I put this badge below or beyond the chapter line of Apache Pulsar manager?
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is better

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, agree with that.


Apache Pulsar manager is a web-based GUI management tool for managing and monitoring Pulsar.

## Feature
Expand Down Expand Up @@ -29,8 +31,6 @@ The puslar-manager supports multiple environment configurations and can manage m
### Manage tenants

![pulsar-manager-tenants](docs/img/pulsar-manager-tenants.gif)
[![FOSSA Status](https://app.fossa.io/api/projects/git%2Bgithub.com%2Fstreamnative%2Fpulsar-manager.svg?type=shield)](https://app.fossa.io/projects/git%2Bgithub.com%2Fstreamnative%2Fpulsar-manager?ref=badge_shield)


### Manage namespaces

Expand Down Expand Up @@ -150,4 +150,4 @@ For more information about the front end, see [pulsar-manager-frontend](https://


## License
[![FOSSA Status](https://app.fossa.io/api/projects/git%2Bgithub.com%2Fstreamnative%2Fpulsar-manager.svg?type=large)](https://app.fossa.io/projects/git%2Bgithub.com%2Fstreamnative%2Fpulsar-manager?ref=badge_large)
[![FOSSA Status](https://app.fossa.io/api/projects/git%2Bgithub.com%2Fstreamnative%2Fpulsar-manager.svg?type=large)](https://app.fossa.io/projects/git%2Bgithub.com%2Fstreamnative%2Fpulsar-manager?ref=badge_large)