Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modern look for the website #426

Closed
wants to merge 33 commits into from
Closed

Conversation

visortelle
Copy link
Member

@visortelle visortelle commented Feb 19, 2023

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Hi everyone!

I don't think anyone will argue, it’s important to have a fresh-looking website to attract new users.

I decided to try to refresh it a little bit.

Over the weekend I managed to make a home page. I think that I can finish other pages in 1-2 weeks, depending on my workload.

Current version: https://pulsar.apache.org/
New version: https://pulsar-site-three.vercel.app/

After the redesign, I plan to add a few more pages.

Should I continue?

Before

Screenshot 2023-02-19 at 11 31 07 PM

After

Screenshot 2023-02-19 at 11 34 18 PM

@visortelle visortelle marked this pull request as draft February 19, 2023 22:35
@Anonymitaet
Copy link
Member

Anonymitaet commented Feb 20, 2023

Hi @visortelle thank you very much for your awsome job! This is a great addition to the Pulsar website!

Many users choose white background since it's more beautiful (modern and clear) and useful (increases readbility). Context see apache/pulsar#15538 (comment).


While I find some issues as below.

1. Content is missing

https://pulsar-site-three.vercel.app/docs/next/
image

2. Content is inconsistent

2.1 https://pulsar-site-three.vercel.app/community/#section-welcome
image

Carousel is more efficient and funny than showing pic one by one.
image

2.2 Can we consolidate them into one table?
https://pulsar-site-three.vercel.app/community/#section-welcome
image

2.3 Same to
image

3. Content is out of order

3.1 All contents on https://pulsar-site-three.vercel.app/case-studies/ are disordered.
image

3.2 Same to
https://pulsar-site-three.vercel.app/resources/
image

3.3 Same to
https://pulsar-site-three.vercel.app/events/
image

@Anonymitaet
Copy link
Member

Anonymitaet commented Feb 20, 2023

Request more review

@emidio-cardeira is working on the visual design

@asafm and @DaveDuggins are working on the copy

Does this change LGTY? Thank you!

FYI @@D-2-Ed @merlimat @jak78

@visortelle
Copy link
Member Author

visortelle commented Feb 20, 2023

@Anonymitaet

I asked only about the home/index/root (/) page look.

Other pages just aren't re-implemented.

I don't know the history behind the previous redesign. I met many situations when people didn't want to consider changes for some reason.

Therefore, I must be sure that the proposed changes most likely will be accepted before investing my time.

@asafm
Copy link
Contributor

asafm commented Feb 20, 2023

Hi @visortelle,
I truly agree with you, the Pulsar website doesn't reflect the awesomeness and how modern Pulsar is. This why @emidio-cardeira, and a few others, are working on a full revamp which will look absolutely stunning. We are currently preparing the PIP, which will show the screenshots of the design and motivation for each change.

@visortelle
Copy link
Member Author

visortelle commented Feb 20, 2023

@asafm I'm glad to hear that work is being done in this direction.

A bit sad that I wasted my time on this. But I remembered how to deal with CSS. 😄

Can't wait to see the PIP.

@asafm
Copy link
Contributor

asafm commented Feb 21, 2023

@visortelle There is the unwritten open source rule: consult before investing large effort :) In Apache Pulsar, DEV mailing list would be the best place for it.

@tisonkun
Copy link
Member

Closing as preferring another initiative.

@asafm @emidio-cardeira do you have an estimate for publishing the PIP? It's good for publicly review a common need instead of long-time in house designing - following the same rule that "consult before investing large effort", lol.

@tisonkun tisonkun closed this Feb 21, 2023
@tisonkun tisonkun removed their request for review February 21, 2023 08:00
@asafm
Copy link
Contributor

asafm commented Feb 21, 2023

@tisonkun 1-2 weeks roughly. We are not publishing a real web-site, but screenshots, so we're not investing a huge effort, but the needed effort to get the actual design approved, and then we'll be able to continue with the large effort itself.

@visortelle
Copy link
Member Author

@asafm sure I will ask before doing something next time.

My wrong assumption was that the previous redesign was not so long time ago, in May 2022. https://lists.apache.org/thread/7nx3rm3cmpbw0ws1b62k17935xgyw2tj
And it's unlikely there planned one more redesign in less than a year.

Anyway, the two days I spent aren't so much, and I have an idea of where I can reuse this code and text.

+1 for the @tisonkun's point.

@Anonymitaet
Copy link
Member

@visortelle you efforts are not wasted because we can still apply it once the community agrees. I'll give my +1 on this beautiful and useful design.

@asafm
Copy link
Contributor

asafm commented Feb 23, 2023

@visortelle PIP released: apache/pulsar#19611

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants