avoid duplicate docbot comment #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tison <wander4096@gmail.com>
nodece
reviewed
Aug 13, 2022
nodece
reviewed
Aug 13, 2022
Signed-off-by: tison <wander4096@gmail.com>
nodece
reviewed
Aug 13, 2022
| @@ -311,6 +311,11 @@ func (a *Action) onPullRequestOpenedOrEdited() error { | |||
|
|
|||
| // Add missing label | |||
| if a.config.GetEnableLabelMissing() && checkedCount == 0 { | |||
| if _, exist := currentLabelsSet[a.config.GetLabelMissing()]; exist { | |||
| logger.Infoln("Already added missing label.") | |||
| return fmt.Errorf("%s", MessageLabelMissing) | |||
There was a problem hiding this comment.
Suggested change
| return fmt.Errorf("%s", MessageLabelMissing) | |
| return nil; |
There was a problem hiding this comment.
We should return the error here. Still the pr needs a valid doc label. We just skip the create comment step.
nodece
reviewed
Aug 13, 2022
|
Sorry that I forget to review the return value. |
nodece
approved these changes
Aug 14, 2022
|
ping @maxsxu @michaeljmarshall |
maxsxu
approved these changes
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should send the comment only once when we add
doc/label-missinglabel once.Otherwise, it may produce duplicate comments which act as spam. For example, apache/pulsar#17009 (comment).
cc @michaeljmarshall @maxsxu @nodece