Fix potential bug getting stats and remove unnecessary error log (#10500

) Co-authored-by: Jerry Peng <jerryp@splunk.com>
apache · May 7, 2021 · 40e3261 · 40e3261
1 parent 37583f6
commit 40e3261
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/...ged-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerFactoryImpl.java b/...ged-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerFactoryImpl.java
@@ -395,7 +395,9 @@ public void initializeComplete() {
 
                 @Override
                 public void initializeFailed(ManagedLedgerException e) {
-                    log.error("[{}] Failed to initialize managed ledger: {}", name, e.getMessage());
+                    if (config.isCreateIfMissing()) {
+                        log.error("[{}] Failed to initialize managed ledger: {}", name, e.getMessage());
+                    }
 
                     // Clean the map if initialization fails
                     ledgers.remove(name, future);

diff --git a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
@@ -1183,7 +1183,7 @@ private void createPersistentTopic(final String topic, boolean createIfMissing,
             return;
         }
 
-        if (!checkMaxTopicsPerNamespace(topicName, 1, topicFuture)) {
+        if (createIfMissing && !checkMaxTopicsPerNamespace(topicName, 1, topicFuture)) {
             return;
         }