Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix potential bug getting stats and remove unnecessary error log #10500

Merged
merged 1 commit into from
May 7, 2021
Merged

Fix potential bug getting stats and remove unnecessary error log #10500

merged 1 commit into from
May 7, 2021

Conversation

jerrypeng
Copy link
Contributor

Motivation

  1. Fix potential bug when calling get stats and maximum number of topics per namespace is set.
  2. Remove unnecessary managed ledger error message when a topic does not exist when getting stats

@jerrypeng jerrypeng added type/bug The PR fixed a bug or issue reported a bug area/broker labels May 7, 2021
@jerrypeng jerrypeng added this to the 2.8.0 milestone May 7, 2021
@jerrypeng jerrypeng self-assigned this May 7, 2021
codelipenghui
codelipenghui reviewed May 7, 2021
View reviewed changes
Copy link
Contributor

@codelipenghui codelipenghui left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jerrypeng Is it possible to add a test to avoid the regression.

@merlimat
Copy link
Contributor

merlimat commented May 7, 2021

@jerrypeng Is it possible to add a test to avoid the regression.

It's a bit difficult and error prone to assert the absence of a certain log.

@merlimat merlimat merged commit 40e3261 into apache:master May 7, 2021
@lhotari lhotari mentioned this pull request May 10, 2021
Closed
eolivelli pushed a commit to eolivelli/pulsar that referenced this pull request May 11, 2021
@jerrypeng @eolivelli
Fix potential bug getting stats and remove unnecessary error log (apa…
8d2342c 
…che#10500)

Co-authored-by: Jerry Peng <jerryp@splunk.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codelipenghui codelipenghui codelipenghui left review comments

@merlimat merlimat merlimat approved these changes

@sijie sijie Awaiting requested review from sijie

@srkukarni srkukarni Awaiting requested review from srkukarni

Assignees

@jerrypeng jerrypeng

Labels
area/broker type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jerrypeng @merlimat @codelipenghui