[java producer] op.cmd may be null, cause NPE (#9400)

* op.cmd may be null, cause NPE * write null in the log
apache · Feb 2, 2021 · 60f6238 · 60f6238
1 parent ca64811
commit 60f6238
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java b/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java
@@ -1484,9 +1484,9 @@ private void resendMessages(ClientCnx cnx) {
      * @param op
      */
     private void stripChecksum(OpSendMsg op) {
-        int totalMsgBufSize = op.cmd.readableBytes();
         ByteBufPair msg = op.cmd;
         if (msg != null) {
+            int totalMsgBufSize = msg.readableBytes();
             ByteBuf headerFrame = msg.getFirst();
             headerFrame.markReaderIndex();
             try {
@@ -1518,8 +1518,7 @@ private void stripChecksum(OpSendMsg op) {
                 headerFrame.resetReaderIndex();
             }
         } else {
-            log.warn("[{}] Failed while casting {} into ByteBufPair", producerName,
-                    (op.cmd == null ? null : op.cmd.getClass().getName()));
+            log.warn("[{}] Failed while casting null into ByteBufPair", producerName);
         }
     }