[java producer] op.cmd may be null, cause NPE #9400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do have seen this problem in production ? or is it just a static analysis of code that led you to this patch ? thanks for sharing your fix |
|
No, just a static analysis of code that led me to this patch。 |
eolivelli
reviewed
Feb 1, 2021
| @@ -1518,8 +1518,7 @@ private void stripChecksum(OpSendMsg op) { | |||
| headerFrame.resetReaderIndex(); | |||
| } | |||
| } else { | |||
| log.warn("[{}] Failed while casting {} into ByteBufPair", producerName, | |||
| (op.cmd == null ? null : op.cmd.getClass().getName())); | |||
| log.warn("[{}] Failed while casting {} into ByteBufPair", producerName, null); | |||
There was a problem hiding this comment.
here you do not need to pass null, you can simply write null in the message
|
I left one suggestion. |
xxxxpenny
changed the title
xxxxpenny
changed the title
|
yeah,I change the title. |
jiazhai
approved these changes
Feb 1, 2021
sijie
approved these changes
Feb 2, 2021
sijie
added
java
type/enhancement
codelipenghui
approved these changes
Feb 2, 2021
Anonymitaet
pushed a commit
that referenced
this pull request
Feb 3, 2021
* op.cmd may be null, cause NPE * write null in the log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check msg = op.cms == null, so use op.cmd. readableBytes() may throw NPE