Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support taking de-duplication snapshots based on time #8237

Closed
3 tasks done
sijie opened this issue Oct 12, 2020 · 1 comment
Closed
3 tasks done

Support taking de-duplication snapshots based on time #8237

sijie opened this issue Oct 12, 2020 · 1 comment
Assignees
Labels
type/feature The PR added a new feature or issue requested a new feature
Milestone

Comments

@sijie
Copy link
Member

sijie commented Oct 12, 2020

Currently we take de-duplication snapshots based on size. If the topic has relatively low traffic, the de-duplication cursor will not move. This can cause messages that are not able to be deleted based on the retention policy. We should add a policy to take de-duplication snapshots based on time.

@315157973
Copy link
Contributor

I will solve it

@codelipenghui codelipenghui added this to the 2.8.0 milestone Nov 4, 2020
codelipenghui pushed a commit that referenced this issue Nov 9, 2020
Master Issue: #8237

### Motivation
Currently we take de-duplication snapshots based on size. If the topic has relatively low traffic, the de-duplication cursor will not move. This can cause messages that are not able to be deleted based on the retention policy. We should add a policy to take de-duplication snapshots based on time.

### Modifications
add a monitor to take snapshot base on time

### Verifying this change
TopicDuplicationTest#testDuplicationSnapshot
codelipenghui pushed a commit that referenced this issue Nov 11, 2020
Master Issue: #8237

### Motivation
Currently we take de-duplication snapshots based on size. If the topic has relatively low traffic, the de-duplication cursor will not move. This can cause messages that are not able to be deleted based on the retention policy. We should add a policy to take de-duplication snapshots based on time.

### Modifications
add api to get/set/remove namespace-level policies

### Verifying this change
TopicDuplicationTest.java
sijie pushed a commit that referenced this issue Nov 16, 2020
Master Issue: #8237

### Motivation
Currently we take de-duplication snapshots based on size. If the topic has relatively low traffic, the de-duplication cursor will not move. This can cause messages that are not able to be deleted based on the retention policy. We should add a policy to take de-duplication snapshots based on time.

### Modifications
add api get/set/remove topic-level `DeduplicationSnapshotInterval`

### Verifying this change
TopicDuplicationTest.java
flowchartsman pushed a commit to flowchartsman/pulsar that referenced this issue Nov 17, 2020
Master Issue: apache#8237

### Motivation
Currently we take de-duplication snapshots based on size. If the topic has relatively low traffic, the de-duplication cursor will not move. This can cause messages that are not able to be deleted based on the retention policy. We should add a policy to take de-duplication snapshots based on time.

### Modifications
add a monitor to take snapshot base on time

### Verifying this change
TopicDuplicationTest#testDuplicationSnapshot
flowchartsman pushed a commit to flowchartsman/pulsar that referenced this issue Nov 17, 2020
Master Issue: apache#8237

### Motivation
Currently we take de-duplication snapshots based on size. If the topic has relatively low traffic, the de-duplication cursor will not move. This can cause messages that are not able to be deleted based on the retention policy. We should add a policy to take de-duplication snapshots based on time.

### Modifications
add api to get/set/remove namespace-level policies

### Verifying this change
TopicDuplicationTest.java
flowchartsman pushed a commit to flowchartsman/pulsar that referenced this issue Nov 17, 2020
Master Issue: apache#8237

### Motivation
Currently we take de-duplication snapshots based on size. If the topic has relatively low traffic, the de-duplication cursor will not move. This can cause messages that are not able to be deleted based on the retention policy. We should add a policy to take de-duplication snapshots based on time.

### Modifications
add api get/set/remove topic-level `DeduplicationSnapshotInterval`

### Verifying this change
TopicDuplicationTest.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature The PR added a new feature or issue requested a new feature
Projects
None yet
Development

No branches or pull requests

4 participants