Support topic-level DeduplicationSnapshotInterval #8552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Nov 13, 2020
...r-broker/src/test/java/org/apache/pulsar/broker/service/persistent/TopicDuplicationTest.java
Outdated
Show resolved
Hide resolved
Huanli-Meng
added
the
doc-required
|
Pulsar Admin API Doc should also be updated. So i add a doc-required label. |
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
sijie
approved these changes
Nov 16, 2020
flowchartsman
pushed a commit
to flowchartsman/pulsar
that referenced
this pull request
Nov 17, 2020
Master Issue: apache#8237 ### Motivation Currently we take de-duplication snapshots based on size. If the topic has relatively low traffic, the de-duplication cursor will not move. This can cause messages that are not able to be deleted based on the retention policy. We should add a policy to take de-duplication snapshots based on time. ### Modifications add api get/set/remove topic-level `DeduplicationSnapshotInterval` ### Verifying this change TopicDuplicationTest.java
1 task
Anonymitaet
added
doc-complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master Issue: #8237
Motivation
Currently we take de-duplication snapshots based on size. If the topic has relatively low traffic, the de-duplication cursor will not move. This can cause messages that are not able to be deleted based on the retention policy. We should add a policy to take de-duplication snapshots based on time.
Modifications
add api get/set/remove topic-level
DeduplicationSnapshotIntervalVerifying this change
TopicDuplicationTest.java