Add underReplicate state in the topic internal stats #10013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codelipenghui
requested review from
sijie,
eolivelli,
rdhabalia,
315157973,
hangc0276,
jiazhai,
merlimat and
zymap
merlimat
reviewed
Mar 23, 2021
| BookKeeperAdmin bookKeeperAdmin = brokerService.pulsar().getBookKeeperAdmin(); | ||
| Collection<BookieId> allBookies; | ||
| try { | ||
| allBookies = bookKeeperAdmin.getAllBookies(); |
There was a problem hiding this comment.
This is mixing a blocking call into an async method. Instead we could be using the MetadataCache to have the list of bookies available.
merlimat
approved these changes
Apr 21, 2021
codelipenghui
added a commit
that referenced
this pull request
Apr 29, 2021
* Add underReplicate state in the topic internal stats * Apply comments. (cherry picked from commit bfba8c8)
pkumar-singh
pushed a commit
to pkumar-singh/pulsar
that referenced
this pull request
Aug 10, 2021
…apache#10013)" This reverts commit bfba8c8.
pkumar-singh
pushed a commit
to pkumar-singh/pulsar
that referenced
this pull request
Aug 10, 2021
…topic internal stats (apache#10013)"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Add underReplicate state in the topic internal stats
If
yeswas chosen, please highlight the changesDocumentation