Fix the possible memory leak of TopicPolicies #10466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sijie
approved these changes
May 4, 2021
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/TopicPoliciesService.java
Outdated
Show resolved
Hide resolved
eolivelli
pushed a commit
to eolivelli/pulsar
that referenced
this pull request
May 11, 2021
### Motivation Topic has been deleted, and the corresponding cache and Listener should also be deleted. Now only the value of the listeners is deleted, the key is not deleted, and the cache is not deleted as well. ### Modifications add clean API to clean cache and listeners ### Verifying this change
2 tasks
codelipenghui
pushed a commit
that referenced
this pull request
Nov 25, 2021
### Motivation `TopicPoliciesService#clean` was introduced to solve listener leaking problem in #10466. And this is already addressed in #12904 using `unregisterListener`. So this method is no use any more, and I don't see any situations that we may use this again. ### Modifications Delete TopicPoliciesService#clean
eolivelli
pushed a commit
to eolivelli/pulsar
that referenced
this pull request
Nov 29, 2021
…#12913) ### Motivation `TopicPoliciesService#clean` was introduced to solve listener leaking problem in apache#10466. And this is already addressed in apache#12904 using `unregisterListener`. So this method is no use any more, and I don't see any situations that we may use this again. ### Modifications Delete TopicPoliciesService#clean
fxbing
pushed a commit
to fxbing/pulsar
that referenced
this pull request
Dec 19, 2021
…#12913) ### Motivation `TopicPoliciesService#clean` was introduced to solve listener leaking problem in apache#10466. And this is already addressed in apache#12904 using `unregisterListener`. So this method is no use any more, and I don't see any situations that we may use this again. ### Modifications Delete TopicPoliciesService#clean
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Topic has been deleted, and the corresponding cache and Listener should also be deleted.
Now only the value of the listeners is deleted, the key is not deleted, and the cache is not deleted as well.
Modifications
add clean API to clean cache and listeners
Verifying this change