[broker] Fix topic policy listener deleted by mistake. #12904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eolivelli
requested changes
Nov 20, 2021
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
Outdated
Show resolved
Hide resolved
codelipenghui
approved these changes
Nov 21, 2021
codelipenghui
added
release/2.8.3
release/2.9.1
type/bug
hangc0276
reviewed
Nov 21, 2021
| if (brokerService.pulsar().getConfig().isSystemTopicEnabled() | ||
| && brokerService.pulsar().getConfig().isTopicLevelPoliciesEnabled()) { | ||
| brokerService.getPulsar().getTopicPoliciesService() | ||
| .unregisterListener(TopicName.getPartitionedTopicName(topic), this); |
There was a problem hiding this comment.
In current unregisterListener implementation, it will make listeners key keep growing even thought the listener unregister called.
There was a problem hiding this comment.
I have optimized the unregister implementation in #12654. See the last line of the unit test,
listMap.get(topicName) returns null instead of empty map.
2 tasks
dlg99
pushed a commit
to dlg99/pulsar
that referenced
this pull request
Nov 23, 2021
### Motivation
Here is the current way of dealing topic policy listeners in PersistentTopic, for example topic name is "A", with 3 partitions.
- Register: call TopicPoliciesService.registerListener("A", listener), for all 3 partitions of topic "A".
- Clean: call TopicPoliciesService.clean("A-partition-x"), here is the problem it will delete all listeners of all partitions of topic "A", if any partition is closed.
This means, if we calls `admin.topics().unload("A-partition-0")`, "A-partition-1" and "A-partition-2" will not be able to receive topic policy update callbacks any more.
A detailed case is designed in the new unit test `testListenerCleanupByPartition`.
### Modifications
With previous optimization of apache#12654 , now we can use `org.apache.pulsar.broker.service.TopicPoliciesService#unregisterListener` to do the clean up.
codelipenghui
pushed a commit
that referenced
this pull request
Nov 25, 2021
### Motivation `TopicPoliciesService#clean` was introduced to solve listener leaking problem in #10466. And this is already addressed in #12904 using `unregisterListener`. So this method is no use any more, and I don't see any situations that we may use this again. ### Modifications Delete TopicPoliciesService#clean
codelipenghui
pushed a commit
that referenced
this pull request
Nov 26, 2021
### Motivation
Here is the current way of dealing topic policy listeners in PersistentTopic, for example topic name is "A", with 3 partitions.
- Register: call TopicPoliciesService.registerListener("A", listener), for all 3 partitions of topic "A".
- Clean: call TopicPoliciesService.clean("A-partition-x"), here is the problem it will delete all listeners of all partitions of topic "A", if any partition is closed.
This means, if we calls `admin.topics().unload("A-partition-0")`, "A-partition-1" and "A-partition-2" will not be able to receive topic policy update callbacks any more.
A detailed case is designed in the new unit test `testListenerCleanupByPartition`.
### Modifications
With previous optimization of #12654 , now we can use `org.apache.pulsar.broker.service.TopicPoliciesService#unregisterListener` to do the clean up.
(cherry picked from commit a0c96a0)
eolivelli
pushed a commit
to eolivelli/pulsar
that referenced
this pull request
Nov 29, 2021
### Motivation
Here is the current way of dealing topic policy listeners in PersistentTopic, for example topic name is "A", with 3 partitions.
- Register: call TopicPoliciesService.registerListener("A", listener), for all 3 partitions of topic "A".
- Clean: call TopicPoliciesService.clean("A-partition-x"), here is the problem it will delete all listeners of all partitions of topic "A", if any partition is closed.
This means, if we calls `admin.topics().unload("A-partition-0")`, "A-partition-1" and "A-partition-2" will not be able to receive topic policy update callbacks any more.
A detailed case is designed in the new unit test `testListenerCleanupByPartition`.
### Modifications
With previous optimization of apache#12654 , now we can use `org.apache.pulsar.broker.service.TopicPoliciesService#unregisterListener` to do the clean up.
eolivelli
pushed a commit
to eolivelli/pulsar
that referenced
this pull request
Nov 29, 2021
…#12913) ### Motivation `TopicPoliciesService#clean` was introduced to solve listener leaking problem in apache#10466. And this is already addressed in apache#12904 using `unregisterListener`. So this method is no use any more, and I don't see any situations that we may use this again. ### Modifications Delete TopicPoliciesService#clean
fxbing
pushed a commit
to fxbing/pulsar
that referenced
this pull request
Dec 19, 2021
### Motivation
Here is the current way of dealing topic policy listeners in PersistentTopic, for example topic name is "A", with 3 partitions.
- Register: call TopicPoliciesService.registerListener("A", listener), for all 3 partitions of topic "A".
- Clean: call TopicPoliciesService.clean("A-partition-x"), here is the problem it will delete all listeners of all partitions of topic "A", if any partition is closed.
This means, if we calls `admin.topics().unload("A-partition-0")`, "A-partition-1" and "A-partition-2" will not be able to receive topic policy update callbacks any more.
A detailed case is designed in the new unit test `testListenerCleanupByPartition`.
### Modifications
With previous optimization of apache#12654 , now we can use `org.apache.pulsar.broker.service.TopicPoliciesService#unregisterListener` to do the clean up.
fxbing
pushed a commit
to fxbing/pulsar
that referenced
this pull request
Dec 19, 2021
…#12913) ### Motivation `TopicPoliciesService#clean` was introduced to solve listener leaking problem in apache#10466. And this is already addressed in apache#12904 using `unregisterListener`. So this method is no use any more, and I don't see any situations that we may use this again. ### Modifications Delete TopicPoliciesService#clean
codelipenghui
pushed a commit
that referenced
this pull request
Dec 21, 2021
### Motivation
Here is the current way of dealing topic policy listeners in PersistentTopic, for example topic name is "A", with 3 partitions.
- Register: call TopicPoliciesService.registerListener("A", listener), for all 3 partitions of topic "A".
- Clean: call TopicPoliciesService.clean("A-partition-x"), here is the problem it will delete all listeners of all partitions of topic "A", if any partition is closed.
This means, if we calls `admin.topics().unload("A-partition-0")`, "A-partition-1" and "A-partition-2" will not be able to receive topic policy update callbacks any more.
A detailed case is designed in the new unit test `testListenerCleanupByPartition`.
### Modifications
With previous optimization of #12654 , now we can use `org.apache.pulsar.broker.service.TopicPoliciesService#unregisterListener` to do the clean up.
(cherry picked from commit a0c96a0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Here is the current way of dealing topic policy listeners in PersistentTopic, for example topic name is "A", with 3 partitions.
This means, if we calls
admin.topics().unload("A-partition-0"), "A-partition-1" and "A-partition-2" will not be able to receive topic policy update callbacks any more.A detailed case is designed in the new unit test
testListenerCleanupByPartition.Modifications
With previous optimization of #12654 , now we can use
org.apache.pulsar.broker.service.TopicPoliciesService#unregisterListenerto do the clean up.Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
no-need-docBug fix.