Add onFilter for Interceptor #10489
Merged
Add onFilter for Interceptor #10489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
approved these changes
May 7, 2021
merlimat
added
the
type/enhancement
eolivelli
pushed a commit
to eolivelli/pulsar
that referenced
this pull request
May 11, 2021
* Add onFilter for Interceptor * code style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The current interceptor is very unfriendly to http processing.
Since the interceptor obtains references to request and response, and many properties of these objects cannot be modified, so we can only read but not modify them.
Therefore, we must wrap request and response. However, the attributes we want to modify are different. Some people want to change the header, and some people want to modify the queryParam. This requires very high flexibility of HttpWrapper.
At least for now it is not supported.
Modifications
Add onFilter for Interceptor, so that we can modify request and response like Filter, user can customize Wrapper
Verifying this change