Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix potential bug getting stats and remove unnecessary error log #10500

Merged
merged 1 commit into from
May 7, 2021
Merged

Fix potential bug getting stats and remove unnecessary error log #10500

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...ged-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerFactoryImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,7 +395,9 @@ public void initializeComplete() {

@Override
public void initializeFailed(ManagedLedgerException e) {
log.error("[{}] Failed to initialize managed ledger: {}", name, e.getMessage());
if (config.isCreateIfMissing()) {
log.error("[{}] Failed to initialize managed ledger: {}", name, e.getMessage());
}

// Clean the map if initialization fails
ledgers.remove(name, future);
Expand Down
2 changes: 1 addition & 1 deletion pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1183,7 +1183,7 @@ private void createPersistentTopic(final String topic, boolean createIfMissing,
return;
}

if (!checkMaxTopicsPerNamespace(topicName, 1, topicFuture)) {
if (createIfMissing && !checkMaxTopicsPerNamespace(topicName, 1, topicFuture)) {
return;
}

Expand Down