-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C++] Avoid sending flow requests with zero permits #10506
Merged
merlimat
merged 2 commits into
apache:master
from
BewareMyPower:bewaremypower/cpp-flow-zero
May 7, 2021
Merged
[C++] Avoid sending flow requests with zero permits #10506
merlimat
merged 2 commits into
apache:master
from
BewareMyPower:bewaremypower/cpp-flow-zero
May 7, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition to the PR description, when a zero queue consumer resumes, the broker's logs will be
|
codelipenghui
approved these changes
May 7, 2021
1 task
merlimat
approved these changes
May 7, 2021
eolivelli
pushed a commit
to eolivelli/pulsar
that referenced
this pull request
May 11, 2021
* Avoid sending zero permits * Avoid the same topic name
codelipenghui
pushed a commit
that referenced
this pull request
May 13, 2021
* Avoid sending zero permits * Avoid the same topic name (cherry picked from commit 37583f6)
eolivelli
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 21, 2021
* Avoid sending zero permits * Avoid the same topic name (cherry picked from commit 37583f6)
@BewareMyPower Clear PR description! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When broker receives a FLOW request with zero permit, an
IllegalArgumentException
will be thrown inServerCnx#handleFlow
and then the connection will be closed so that the consumer will reconnect to the broker. IfresumeMessageListener()
was called for a zero queue consumer, the permits may be zero and trigger a reconnection. The frequent reconnections may cause messages repeated or out of order.Modifications
Verifying this change
This change added tests
ZeroQueueSizeTest#testPauseResumeNoReconnection
.