[Java Client] Avoid sending flow requests with zero permits #10507
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It's the Java client side fix for #10506.
When broker receives a FLOW request with zero permit, an IllegalArgumentException will be thrown in
ServerCnx#handleFlow
and then the connection will be closed so that the consumer will reconnect to the broker. Ifresume()
was called for a zero queue consumer, the permits may be zero and trigger a reconnection. The frequent reconnections may cause messages repeated or out of order.Modifications
Verifying this change
This change added tests
ZeroQueueSizeTest#testPauseAndResumeNoReconnection
.