use zookeeper prometheus metric provider to export zookeeper metrics #10803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hangc0276
requested review from
lhotari,
Jennifer88huang-zz,
eolivelli,
315157973 and
codelipenghui
|
This sounds like a bug that should be highlighted in the release notes of 2.8.0 |
sijie
approved these changes
Jun 3, 2021
eolivelli
approved these changes
Jun 3, 2021
codelipenghui
approved these changes
Jun 3, 2021
merlimat
reviewed
Jun 3, 2021
| port, e); | ||
| throw e; | ||
| } | ||
|
|
||
| // Start the regular ZooKeeper server | ||
| QuorumPeerMain.main(args); |
There was a problem hiding this comment.
Since there is nothing left in this class, we can remove it and just call QuorumMain from the CLI scripts
There was a problem hiding this comment.
OK，just call QuorumMain from CLI scripts is better, i update it.
codelipenghui
pushed a commit
that referenced
this pull request
Jun 5, 2021
…tart zookeeper (#10823) ### Motivation After upgrade zookeeper to 3.6.0+ and use zookeeper prometheus provider to provider metrics, we remote pulsar zookeeper prometheus metrics in #10803. We may remove the pulsar-zookeeper module and call zookeeper quorumPeerMain to start zookeeper directly in bin/pulsar script. ### Modifications 1. remove `pulsar-zookeeper` module 2. call zookeeper quorumPeerMain to start zookeeper in `bin/pulsar` script
yangl
pushed a commit
to yangl/pulsar
that referenced
this pull request
Jun 23, 2021
…pache#10803) ### Motivation After upgrade zookeeper version to 3.6.2 in apache#8590 and removed AspectJ based metrics for ZooKeeper in apache#10533, the zookeeper's prometheus metric has lost if we start zookeeper by `bin/puldar-daemon start zookeeper`. Due to zookeeper 3.6.0+ has add internal prometheus metric provider, so we can turn on by default in pulsar. ### Modification 1. turn on zookeeper prometheus metric provider by default in `conf/zookeeper.conf` and use 8000 as default port sync with old zookeeper metric port 2. add grafana panel for new zookeeper metrics 3. remove old prometheus metric provider in `ZooKeeperStarter` and `ConfigurationStoreStarter`. 4. update reference-metric.md doc
yangl
pushed a commit
to yangl/pulsar
that referenced
this pull request
Jun 23, 2021
…tart zookeeper (apache#10823) ### Motivation After upgrade zookeeper to 3.6.0+ and use zookeeper prometheus provider to provider metrics, we remote pulsar zookeeper prometheus metrics in apache#10803. We may remove the pulsar-zookeeper module and call zookeeper quorumPeerMain to start zookeeper directly in bin/pulsar script. ### Modifications 1. remove `pulsar-zookeeper` module 2. call zookeeper quorumPeerMain to start zookeeper in `bin/pulsar` script
pkumar-singh
pushed a commit
to pkumar-singh/pulsar
that referenced
this pull request
Aug 10, 2021
…pache#10803) After upgrade zookeeper version to 3.6.2 in apache#8590 and removed AspectJ based metrics for ZooKeeper in apache#10533, the zookeeper's prometheus metric has lost if we start zookeeper by `bin/puldar-daemon start zookeeper`. Due to zookeeper 3.6.0+ has add internal prometheus metric provider, so we can turn on by default in pulsar. 1. turn on zookeeper prometheus metric provider by default in `conf/zookeeper.conf` and use 8000 as default port sync with old zookeeper metric port 2. add grafana panel for new zookeeper metrics 3. remove old prometheus metric provider in `ZooKeeperStarter` and `ConfigurationStoreStarter`. 4. update reference-metric.md doc
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
…pache#10803) ### Motivation After upgrade zookeeper version to 3.6.2 in apache#8590 and removed AspectJ based metrics for ZooKeeper in apache#10533, the zookeeper's prometheus metric has lost if we start zookeeper by `bin/puldar-daemon start zookeeper`. Due to zookeeper 3.6.0+ has add internal prometheus metric provider, so we can turn on by default in pulsar. ### Modification 1. turn on zookeeper prometheus metric provider by default in `conf/zookeeper.conf` and use 8000 as default port sync with old zookeeper metric port 2. add grafana panel for new zookeeper metrics 3. remove old prometheus metric provider in `ZooKeeperStarter` and `ConfigurationStoreStarter`. 4. update reference-metric.md doc
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
…tart zookeeper (apache#10823) ### Motivation After upgrade zookeeper to 3.6.0+ and use zookeeper prometheus provider to provider metrics, we remote pulsar zookeeper prometheus metrics in apache#10803. We may remove the pulsar-zookeeper module and call zookeeper quorumPeerMain to start zookeeper directly in bin/pulsar script. ### Modifications 1. remove `pulsar-zookeeper` module 2. call zookeeper quorumPeerMain to start zookeeper in `bin/pulsar` script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
After upgrade zookeeper version to 3.6.2 in #8590 and removed AspectJ based metrics for ZooKeeper in #10533, the zookeeper's prometheus metric has lost if we start zookeeper by
bin/puldar-daemon start zookeeper.Due to zookeeper 3.6.0+ has add internal prometheus metric provider, so we can turn on by default in pulsar.
Modification
conf/zookeeper.confand use 8000 as default port sync with old zookeeper metric portZooKeeperStarterandConfigurationStoreStarter.