-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use zookeeper prometheus metric provider to export zookeeper metrics #10803
use zookeeper prometheus metric provider to export zookeeper metrics #10803
Conversation
This sounds like a bug that should be highlighted in the release notes of 2.8.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The metrics exported by the default Metrics Provider in ZooKeeper are different from the ones we exported previously in Pulsar 2.7.x.
We should note this in the release notes.
port, e); | ||
throw e; | ||
} | ||
|
||
// Start the regular ZooKeeper server | ||
QuorumPeerMain.main(args); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there is nothing left in this class, we can remove it and just call QuorumMain from the CLI scripts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK,just call QuorumMain from CLI scripts is better, i update it.
…tart zookeeper (#10823) ### Motivation After upgrade zookeeper to 3.6.0+ and use zookeeper prometheus provider to provider metrics, we remote pulsar zookeeper prometheus metrics in #10803. We may remove the pulsar-zookeeper module and call zookeeper quorumPeerMain to start zookeeper directly in bin/pulsar script. ### Modifications 1. remove `pulsar-zookeeper` module 2. call zookeeper quorumPeerMain to start zookeeper in `bin/pulsar` script
…pache#10803) ### Motivation After upgrade zookeeper version to 3.6.2 in apache#8590 and removed AspectJ based metrics for ZooKeeper in apache#10533, the zookeeper's prometheus metric has lost if we start zookeeper by `bin/puldar-daemon start zookeeper`. Due to zookeeper 3.6.0+ has add internal prometheus metric provider, so we can turn on by default in pulsar. ### Modification 1. turn on zookeeper prometheus metric provider by default in `conf/zookeeper.conf` and use 8000 as default port sync with old zookeeper metric port 2. add grafana panel for new zookeeper metrics 3. remove old prometheus metric provider in `ZooKeeperStarter` and `ConfigurationStoreStarter`. 4. update reference-metric.md doc
…tart zookeeper (apache#10823) ### Motivation After upgrade zookeeper to 3.6.0+ and use zookeeper prometheus provider to provider metrics, we remote pulsar zookeeper prometheus metrics in apache#10803. We may remove the pulsar-zookeeper module and call zookeeper quorumPeerMain to start zookeeper directly in bin/pulsar script. ### Modifications 1. remove `pulsar-zookeeper` module 2. call zookeeper quorumPeerMain to start zookeeper in `bin/pulsar` script
…pache#10803) After upgrade zookeeper version to 3.6.2 in apache#8590 and removed AspectJ based metrics for ZooKeeper in apache#10533, the zookeeper's prometheus metric has lost if we start zookeeper by `bin/puldar-daemon start zookeeper`. Due to zookeeper 3.6.0+ has add internal prometheus metric provider, so we can turn on by default in pulsar. 1. turn on zookeeper prometheus metric provider by default in `conf/zookeeper.conf` and use 8000 as default port sync with old zookeeper metric port 2. add grafana panel for new zookeeper metrics 3. remove old prometheus metric provider in `ZooKeeperStarter` and `ConfigurationStoreStarter`. 4. update reference-metric.md doc
…pache#10803) ### Motivation After upgrade zookeeper version to 3.6.2 in apache#8590 and removed AspectJ based metrics for ZooKeeper in apache#10533, the zookeeper's prometheus metric has lost if we start zookeeper by `bin/puldar-daemon start zookeeper`. Due to zookeeper 3.6.0+ has add internal prometheus metric provider, so we can turn on by default in pulsar. ### Modification 1. turn on zookeeper prometheus metric provider by default in `conf/zookeeper.conf` and use 8000 as default port sync with old zookeeper metric port 2. add grafana panel for new zookeeper metrics 3. remove old prometheus metric provider in `ZooKeeperStarter` and `ConfigurationStoreStarter`. 4. update reference-metric.md doc
…tart zookeeper (apache#10823) ### Motivation After upgrade zookeeper to 3.6.0+ and use zookeeper prometheus provider to provider metrics, we remote pulsar zookeeper prometheus metrics in apache#10803. We may remove the pulsar-zookeeper module and call zookeeper quorumPeerMain to start zookeeper directly in bin/pulsar script. ### Modifications 1. remove `pulsar-zookeeper` module 2. call zookeeper quorumPeerMain to start zookeeper in `bin/pulsar` script
Motivation
After upgrade zookeeper version to 3.6.2 in #8590 and removed AspectJ based metrics for ZooKeeper in #10533, the zookeeper's prometheus metric has lost if we start zookeeper by
bin/puldar-daemon start zookeeper
.Due to zookeeper 3.6.0+ has add internal prometheus metric provider, so we can turn on by default in pulsar.
Modification
conf/zookeeper.conf
and use 8000 as default port sync with old zookeeper metric portZooKeeperStarter
andConfigurationStoreStarter
.