remove pulsar-zookeeper module and call zookeeper quorumPeerMain to start zookeeper #10823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…irect start zookeeper
hangc0276
requested review from
merlimat,
lhotari,
eolivelli,
codelipenghui and
sijie
merlimat
approved these changes
Jun 4, 2021
codelipenghui
approved these changes
Jun 4, 2021
|
/pulsarbot run-failure-checks |
yangl
pushed a commit
to yangl/pulsar
that referenced
this pull request
Jun 23, 2021
…tart zookeeper (apache#10823) ### Motivation After upgrade zookeeper to 3.6.0+ and use zookeeper prometheus provider to provider metrics, we remote pulsar zookeeper prometheus metrics in apache#10803. We may remove the pulsar-zookeeper module and call zookeeper quorumPeerMain to start zookeeper directly in bin/pulsar script. ### Modifications 1. remove `pulsar-zookeeper` module 2. call zookeeper quorumPeerMain to start zookeeper in `bin/pulsar` script
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
…tart zookeeper (apache#10823) ### Motivation After upgrade zookeeper to 3.6.0+ and use zookeeper prometheus provider to provider metrics, we remote pulsar zookeeper prometheus metrics in apache#10803. We may remove the pulsar-zookeeper module and call zookeeper quorumPeerMain to start zookeeper directly in bin/pulsar script. ### Modifications 1. remove `pulsar-zookeeper` module 2. call zookeeper quorumPeerMain to start zookeeper in `bin/pulsar` script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
After upgrade zookeeper to 3.6.0+ and use zookeeper prometheus provider to provider metrics, we remote pulsar zookeeper prometheus metrics in #10803. We may remove the pulsar-zookeeper module and call zookeeper quorumPeerMain to start zookeeper directly in bin/pulsar script.
Modifications
pulsar-zookeepermodulebin/pulsarscript