Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Fix functions main profile activation by default #10887

Merged
merged 1 commit into from Jun 18, 2021

Conversation

murong00
Copy link
Contributor

Motivation

Similar to #10814, functions module build failed due to the falg activeByDefault fail to activate the profile if any other profile is activated.

Modifications

  • Use a better solution to activate the main profile by default by using a property value with inversion (!) rule.

Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@murong00
Copy link
Contributor Author

/pulsarbot run-failure-checks

@sijie sijie added this to the 2.9.0 milestone Jun 18, 2021
@sijie sijie merged commit d9a8857 into apache:master Jun 18, 2021
yangl pushed a commit to yangl/pulsar that referenced this pull request Jun 23, 2021
### Motivation

Similar to apache#10814, functions module build failed due to the falg `activeByDefault` fail to activate the profile if any other profile is activated.

### Modifications

- Use a better solution to activate the `main` profile by default by using a property value with inversion (`!`) rule.
bharanic-dev pushed a commit to bharanic-dev/pulsar that referenced this pull request Mar 18, 2022
### Motivation

Similar to apache#10814, functions module build failed due to the falg `activeByDefault` fail to activate the profile if any other profile is activated.

### Modifications

- Use a better solution to activate the `main` profile by default by using a property value with inversion (`!`) rule.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants