[Build] Fix main profile activation by default #10814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eolivelli
approved these changes
Jun 3, 2021
codelipenghui
approved these changes
Jun 3, 2021
sijie
pushed a commit
that referenced
this pull request
Jun 18, 2021
### Motivation Similar to #10814, functions module build failed due to the falg `activeByDefault` fail to activate the profile if any other profile is activated. ### Modifications - Use a better solution to activate the `main` profile by default by using a property value with inversion (`!`) rule.
yangl
pushed a commit
to yangl/pulsar
that referenced
this pull request
Jun 23, 2021
- Use a better solution to activate the main profile by default by using a property value with inversion (!) rule. - The previous solution used <exists><file>pom.xml</file></exists> which doesn't work in all cases for some reason. - In maven, activeByDefault works only if no other profile is already active. This isn't usable since there's already a profile called jdk11 which is active.
yangl
pushed a commit
to yangl/pulsar
that referenced
this pull request
Jun 23, 2021
### Motivation Similar to apache#10814, functions module build failed due to the falg `activeByDefault` fail to activate the profile if any other profile is activated. ### Modifications - Use a better solution to activate the `main` profile by default by using a property value with inversion (`!`) rule.
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
- Use a better solution to activate the main profile by default by using a property value with inversion (!) rule. - The previous solution used <exists><file>pom.xml</file></exists> which doesn't work in all cases for some reason. - In maven, activeByDefault works only if no other profile is already active. This isn't usable since there's already a profile called jdk11 which is active.
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
### Motivation Similar to apache#10814, functions module build failed due to the falg `activeByDefault` fail to activate the profile if any other profile is activated. ### Modifications - Use a better solution to activate the `main` profile by default by using a property value with inversion (`!`) rule.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10791
Motivation
<exists><file>pom.xml</file></exists>which doesn't work in all cases for some reason. That solution was added as part of JDK11 changes in [Build] Fix core-modules profile on JDK11 #10340. There's a reported issue "mvn package" has not built any jar #10791 about the problem in activating themainprofile.Additional context
activeByDefaultworks only if no other profile is already active.jdk11was added which gets activated when JDK version >= 11. This broke theactiveByDefaultsolution for activating themainprofile.Modifications
mainprofile by default by using a property value with inversion (!) rule.