[Broker/Bookie] Set -Dio.netty.tryReflectionSetAccessible=true for pulsar processes #11138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l pulsar processes - enables Netty to use UnpooledUnsafeNoCleanerDirectByteBuf in JDK9+ (JDK 11 in this case) - fixes jvm_memory_direct_bytes_used metric for Bookie
lhotari
requested review from
eolivelli,
merlimat,
rdhabalia,
sijie,
codelipenghui and
addisonj
lhotari
added a commit
to datastax/pulsar
that referenced
this pull request
Jun 30, 2021
…lsar processes - allows Netty to use reflection access on JDK9+ - fixes jvm_memory_direct_bytes_used Prometheus metric for Bookkeeper (Bookie). The direct memory usage metrics are disabled in Bookie on JDK11 unless -Dio.netty.tryReflectionSetAccessible=true is used. - enables Netty to use more efficient byte buffer implementation such as UnpooledUnsafeNoCleanerDirectByteBuf in JDK9+ (JDK 11 in this case). This is already used in JDK8. In JDK9+, it is necessary to set -Dio.netty.tryReflectionSetAccessible=true to use UnpooledUnsafeNoCleanerDirectByteBuf. This is necessary for preventing performance regressions in this area. upstream PR apache#11138
sijie
approved these changes
Jun 30, 2021
lhotari
added a commit
to datastax/pulsar
that referenced
this pull request
Jul 2, 2021
…lsar processes (apache#11138) - allows Netty to use reflection access on JDK9+ - fixes `jvm_memory_direct_bytes_used` Prometheus metric for Bookkeeper (Bookie). The direct memory usage metrics are disabled in Bookie on JDK11 unless `-Dio.netty.tryReflectionSetAccessible=true` is used. - enables Netty to use more efficient byte buffer implementation such as UnpooledUnsafeNoCleanerDirectByteBuf in JDK9+ (JDK 11 in this case). This is already used in JDK8. In JDK9+, it is necessary to set `-Dio.netty.tryReflectionSetAccessible=true` to use UnpooledUnsafeNoCleanerDirectByteBuf. This is necessary for preventing performance regressions in this area. - pass `-Dio.netty.tryReflectionSetAccessible=true` JVM option by default to all pulsar process started with `bin/pulsar` script. (cherry picked from commit f0cbcb5)
codelipenghui
pushed a commit
that referenced
this pull request
Jul 7, 2021
…lsar processes (#11138) ### Motivation - allows Netty to use reflection access on JDK9+ - fixes `jvm_memory_direct_bytes_used` Prometheus metric for Bookkeeper (Bookie). The direct memory usage metrics are disabled in Bookie on JDK11 unless `-Dio.netty.tryReflectionSetAccessible=true` is used. - enables Netty to use more efficient byte buffer implementation such as UnpooledUnsafeNoCleanerDirectByteBuf in JDK9+ (JDK 11 in this case). This is already used in JDK8. In JDK9+, it is necessary to set `-Dio.netty.tryReflectionSetAccessible=true` to use UnpooledUnsafeNoCleanerDirectByteBuf. This is necessary for preventing performance regressions in this area. ### Modifications - pass `-Dio.netty.tryReflectionSetAccessible=true` JVM option by default to all pulsar process started with `bin/pulsar` script. (cherry picked from commit f0cbcb5)
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
…lsar processes (apache#11138) ### Motivation - allows Netty to use reflection access on JDK9+ - fixes `jvm_memory_direct_bytes_used` Prometheus metric for Bookkeeper (Bookie). The direct memory usage metrics are disabled in Bookie on JDK11 unless `-Dio.netty.tryReflectionSetAccessible=true` is used. - enables Netty to use more efficient byte buffer implementation such as UnpooledUnsafeNoCleanerDirectByteBuf in JDK9+ (JDK 11 in this case). This is already used in JDK8. In JDK9+, it is necessary to set `-Dio.netty.tryReflectionSetAccessible=true` to use UnpooledUnsafeNoCleanerDirectByteBuf. This is necessary for preventing performance regressions in this area. ### Modifications - pass `-Dio.netty.tryReflectionSetAccessible=true` JVM option by default to all pulsar process started with `bin/pulsar` script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
jvm_memory_direct_bytes_usedPrometheus metric for Bookkeeper (Bookie). The direct memory usage metrics are disabled in Bookie on JDK11 unless-Dio.netty.tryReflectionSetAccessible=trueis used.-Dio.netty.tryReflectionSetAccessible=trueto use UnpooledUnsafeNoCleanerDirectByteBuf. This is necessary for preventing performance regressions in this area.Modifications
-Dio.netty.tryReflectionSetAccessible=trueJVM option by default to all pulsar process started withbin/pulsarscript.