Make the compaction phase one loop timeout configurable #11206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codelipenghui
requested review from
lhotari,
sijie,
eolivelli,
315157973,
addisonj,
hangc0276 and
merlimat
and removed request for
lhotari
codelipenghui
added
release/2.7.3
release/2.8.1
type/enhancement
hangc0276
approved these changes
Jul 3, 2021
315157973
approved these changes
Jul 3, 2021
merlimat
approved these changes
Jul 3, 2021
conf/broker.conf
Outdated
| @@ -450,6 +450,10 @@ brokerServiceCompactionMonitorIntervalInSeconds=60 | |||
| # Using a value of 0, is disabling compression check. | |||
| brokerServiceCompactionThresholdInBytes=0 | |||
|
|
|||
| # Timeout for the compaction phase one loop. | |||
| # If the execution time of the compaction phase one loop exceeds this time, the compaction will not proceed. | |||
| brokerServiceCompactionPhaseOneLoopTimeInSeconds=10 | |||
There was a problem hiding this comment.
Most of the other timeouts are set to 30seconds. Maybe we could also switch this default value to 30.
codelipenghui
added a commit
that referenced
this pull request
Jul 4, 2021
(cherry picked from commit 96e4fd6)
codelipenghui
added a commit
that referenced
this pull request
Jul 7, 2021
(cherry picked from commit 96e4fd6)
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.