-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the compaction phase one loop timeout configurable #11206
Make the compaction phase one loop timeout configurable #11206
Conversation
conf/broker.conf
Outdated
@@ -450,6 +450,10 @@ brokerServiceCompactionMonitorIntervalInSeconds=60 | |||
# Using a value of 0, is disabling compression check. | |||
brokerServiceCompactionThresholdInBytes=0 | |||
|
|||
# Timeout for the compaction phase one loop. | |||
# If the execution time of the compaction phase one loop exceeds this time, the compaction will not proceed. | |||
brokerServiceCompactionPhaseOneLoopTimeInSeconds=10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the other timeouts are set to 30seconds. Maybe we could also switch this default value to 30.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
(cherry picked from commit 96e4fd6)
(cherry picked from commit 96e4fd6)
No description provided.