[Branch-2.7] Fix broker dispatch byte rate limiter #11249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaoran10
requested review from
315157973,
codelipenghui,
congbobo184,
eolivelli and
zymap
codelipenghui
approved these changes
Jul 8, 2021
315157973
approved these changes
Jul 8, 2021
congbobo184
approved these changes
Jul 8, 2021
gaoran10
force-pushed
the
fix-dispatcher-byte-limit-2.7
branch
from
b9a6f74
to
eece4a7
Compare
gaoran10
force-pushed
the
fix-dispatcher-byte-limit-2.7
branch
from
eece4a7
to
061a917
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR #11135 couldn't be cherry-picked to branch-2.7, because there are too many conflicts.
Motivation
fix #11044
now dispatcher byte rate limit don't limit every cursor read. When cursor read always use
ServiceConfiguration.dispatcherMaxReadSizeBytesto read. It will cause that dispatcher read entries byServiceConfiguration.dispatcherMaxReadSizeBytesto read every time.implement
when cursor read entries size need to calculate, the calculate result by dispatcher bytes limiter.
Verifying this change
Add the tests for it
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes
Dependencies (does it add or upgrade a dependency): (no)
The public API: (no)
The schema: (no)
The default values of configurations: (no)
The wire protocol: (no)
The rest endpoints: (no)
The admin cli options: (no)
Anything that affects deployment: (no)