-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add error log for schema admin operation #11427
Conversation
@wangjialing218 Thanks for your contribution. For this PR, do we need to update docs? (The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks) |
I think this PR do not need to update docs |
/pulsarbot run-failure-checks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome work, very useful
LGTM
I left one minor comment, PTAL
@@ -294,4 +302,6 @@ private void validateDestinationAndAdminOperation(boolean authoritative) { | |||
} | |||
} | |||
} | |||
|
|||
private static final Logger log = LoggerFactory.getLogger(SchemasResourceBase.class); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:
please use @Slf4j
annotation from lombok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I just copied this usage from other Class like 'TenantsBase' in same package, we could change to @Slf4j
for all those Class in another PR.
### Motivation When I use pulsar-admin schemas to upload schema file with wrong format, I got `HTTP 500 Internal Server Error` from pulsar-admin-tool. And I look into broker's log but can not find any related error logs. ### Modifications export error log when schema admin operation failed. (cherry picked from commit 216623d)
### Motivation When I use pulsar-admin schemas to upload schema file with wrong format, I got `HTTP 500 Internal Server Error` from pulsar-admin-tool. And I look into broker's log but can not find any related error logs. ### Modifications export error log when schema admin operation failed.
Motivation
When I use pulsar-admin schemas to upload schema file with wrong format, I got
HTTP 500 Internal Server Error
from pulsar-admin-tool.And I look into broker's log but can not find any related error logs.
Modifications
export error log when schema admin operation failed.