add error log for schema admin operation #11427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wangjialing218 Thanks for your contribution. For this PR, do we need to update docs? (The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks) |
|
I think this PR do not need to update docs |
|
/pulsarbot run-failure-checks |
eolivelli
approved these changes
Jul 23, 2021
| @@ -294,4 +302,6 @@ private void validateDestinationAndAdminOperation(boolean authoritative) { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| private static final Logger log = LoggerFactory.getLogger(SchemasResourceBase.class); | |||
There was a problem hiding this comment.
nit:
please use @Slf4j annotation from lombok
There was a problem hiding this comment.
Thanks. I just copied this usage from other Class like 'TenantsBase' in same package, we could change to @Slf4j for all those Class in another PR.
codelipenghui
approved these changes
Jul 23, 2021
codelipenghui
added
release/2.8.1
type/enhancement
codelipenghui
pushed a commit
that referenced
this pull request
Jul 30, 2021
### Motivation When I use pulsar-admin schemas to upload schema file with wrong format, I got `HTTP 500 Internal Server Error` from pulsar-admin-tool. And I look into broker's log but can not find any related error logs. ### Modifications export error log when schema admin operation failed. (cherry picked from commit 216623d)
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
### Motivation When I use pulsar-admin schemas to upload schema file with wrong format, I got `HTTP 500 Internal Server Error` from pulsar-admin-tool. And I look into broker's log but can not find any related error logs. ### Modifications export error log when schema admin operation failed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When I use pulsar-admin schemas to upload schema file with wrong format, I got
HTTP 500 Internal Server Errorfrom pulsar-admin-tool.And I look into broker's log but can not find any related error logs.
Modifications
export error log when schema admin operation failed.