Deep copy the tenants to avoid concurrent sort exception #11463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shoothzj
force-pushed
the
master
branch
6 times, most recently
from
9fa2cb1
to
42cf146
Compare
codelipenghui
approved these changes
Jul 27, 2021
codelipenghui
added
release/2.8.1
type/bug
shoothzj
force-pushed
the
master
branch
2 times, most recently
from
653ca2b
to
34e13e9
Compare
shoothzj
force-pushed
the
master
branch
3 times, most recently
from
9fc4dc7
to
5f0f519
Compare
sijie
approved these changes
Jul 28, 2021
shoothzj
force-pushed
the
master
branch
5 times, most recently
from
f32f141
to
28cd485
Compare
BewareMyPower
approved these changes
Jul 29, 2021
codelipenghui
pushed a commit
that referenced
this pull request
Jul 30, 2021
(cherry picked from commit 191dc62)
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, the sort of tenants can be accessed from multi threads(pulsar-web jetty threads), which tenants are acquired from cache. So the concurrent sort of
tenantscould arise concurrent modification exception.Modifications
Before the tenants sort, deep copy the list to avoid concurrent access.
Documentation
For this PR, we don't need to update docs, because changes not visible from api.