Add backoff for setting for getting topic policies. #11487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, if we start a new broker which does not owned any namepsaces bundles. Then when use the pulsar-admin to setting or getting topic policies, we will get `topic policies have not been initialized yet` error log and the admin operation will get failed. The root cause is we are failed immediately without any retry while the topic polices cache have not init yet. So the PR to introduce the backoff for setting or getting the topic policy if encounter the topic policies cache not init exception
codelipenghui
added
type/enhancement
codelipenghui
requested review from
315157973,
BewareMyPower,
congbobo184,
gaoran10,
hangc0276,
merlimat,
sijie and
zymap
sijie
approved these changes
Jul 28, 2021
zymap
approved these changes
Jul 29, 2021
hangc0276
requested changes
Jul 29, 2021
| * @param topicName | ||
| * @return | ||
| */ | ||
| boolean cacheIsInitialized(TopicName topicName); |
There was a problem hiding this comment.
The interface mark as Deprecated instead of directly delete?
There was a problem hiding this comment.
This method does not been used by the client-side, after checking the reference to this method, all of them are from the test class, I think we can delete it directly since we are not exposing the interface for users to implement their own topic policies service implementation.
hangc0276
approved these changes
Jul 29, 2021
|
Good job! |
315157973
approved these changes
Jul 29, 2021
codelipenghui
added a commit
that referenced
this pull request
Jul 30, 2021
Currently, if we start a new broker which does not owned any namepsaces bundles. Then when use the pulsar-admin to setting or getting topic policies, we will get `topic policies have not been initialized yet` error log and the admin operation will get failed. The root cause is we are failed immediately without any retry while the topic polices cache have not init yet. So the PR to introduce the backoff for setting or getting the topic policy if encounter the topic policies cache not init exception Remove the cache init check for the tests. (cherry picked from commit bebaadf)
codelipenghui
added a commit
to codelipenghui/incubator-pulsar
that referenced
this pull request
Aug 4, 2021
codelipenghui
added a commit
that referenced
this pull request
Aug 5, 2021
* Fix some topic policy operation without backoff Related to #11487
Technoboy-
added a commit
to Technoboy-/pulsar
that referenced
this pull request
Aug 5, 2021
Technoboy-
added a commit
to Technoboy-/pulsar
that referenced
this pull request
Aug 5, 2021
codelipenghui
added a commit
that referenced
this pull request
Aug 6, 2021
Technoboy-
added a commit
to Technoboy-/pulsar
that referenced
this pull request
Aug 6, 2021
Technoboy-
added a commit
to Technoboy-/pulsar
that referenced
this pull request
Aug 6, 2021
Technoboy-
added a commit
to Technoboy-/pulsar
that referenced
this pull request
Aug 9, 2021
LeBW
pushed a commit
to LeBW/pulsar
that referenced
this pull request
Aug 9, 2021
* Fix some topic policy operation without backoff Related to apache#11487
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
### Motivation Currently, if we start a new broker which does not owned any namepsaces bundles. Then when use the pulsar-admin to setting or getting topic policies, we will get `topic policies have not been initialized yet` error log and the admin operation will get failed. The root cause is we are failed immediately without any retry while the topic polices cache have not init yet. So the PR to introduce the backoff for setting or getting the topic policy if encounter the topic policies cache not init exception ### Verifying this change Remove the cache init check for the tests.
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
* Fix some topic policy operation without backoff Related to apache#11487
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, if we start a new broker which does not owned any namepsaces bundles.
Then when use the pulsar-admin to setting or getting topic policies, we will get
topic policies have not been initialized yeterror log and the admin operation willget failed.
The root cause is we are failed immediately without any retry while the topic polices
cache have not init yet. So the PR to introduce the backoff for setting or getting
the topic policy if encounter the topic policies cache not init exception
Verifying this change
Remove the cache init check for the tests.
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changes