Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cherry-pick] Add backoff for setting for getting topic policies to branch-2.7 #11574

Merged

Conversation

Technoboy-
Copy link
Contributor

@Technoboy- Technoboy- commented Aug 5, 2021

##Motivation
Cherry pick - Add backoff for setting for getting topic policies(#11487, #11560) to branch-2.7.
For some of the methods are different with the master branch, using git cherrypick -x will be failed. So I have to move the changes one by one.

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please write in the description, and possibly the title, a summary of the changes?

Otherwise it is tricky for people reading the release notes and the commit messages to understand the meaning of this patch.

@eolivelli
Copy link
Contributor

Why didn't you use 'git cherrypick -x'?

If you do it that way there is a better link to the original commits.
If they do not apply cleanly please explain

@Technoboy- Technoboy- changed the title Cherry pick #11487 and #11560 to branch-2.7 [Cherry-pick] Add backoff for setting for getting topic policies Aug 6, 2021
@Technoboy- Technoboy- changed the title [Cherry-pick] Add backoff for setting for getting topic policies [Cherry-pick] Add backoff for setting for getting topic policies to branch-2.7 Aug 6, 2021
@Technoboy-
Copy link
Contributor Author

Can you please write in the description, and possibly the title, a summary of the changes?

Otherwise it is tricky for people reading the release notes and the commit messages to understand the meaning of this patch.

Sorry for this, I have changed the description.

Technoboy- added a commit to Technoboy-/pulsar that referenced this pull request Aug 6, 2021
@Technoboy-
Copy link
Contributor Author

Why didn't you use 'git cherrypick -x'?

If you do it that way there is a better link to the original commits.
If they do not apply cleanly please explain

For some of the methods are different with the master branch, using git cherrypick -x will be failed. So I have to move the changes one by one.

@codelipenghui
Copy link
Contributor

@eolivelli

Why didn't you use 'git cherrypick -x'?

There are too many conflicts with branch-2.7. we are not able to cherry-pick the change from the master branch, so push a PR to fix the branch-2.7 directly.

@Anonymitaet Anonymitaet added the doc-not-needed Your PR changes do not impact docs label Aug 9, 2021
@codelipenghui codelipenghui merged commit 9bd54a9 into apache:branch-2.7 Aug 9, 2021
@codelipenghui codelipenghui added the cherry-picked/branch-2.7 Archived: 2.7 is end of life label Aug 9, 2021
@Technoboy- Technoboy- deleted the cherry-pick-11487-and-11560 branch August 10, 2022 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-picked/branch-2.7 Archived: 2.7 is end of life doc-not-needed Your PR changes do not impact docs release/2.7.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants